tests/test_ansi2html.py: use sys.executable instead of hardcoded python3 #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
approved these changes
May 9, 2023
Collaborator
There was a problem hiding this comment.
While the change looks good in isolation, to get a green CI at https://github.com/pycontribs/ansi2html/actions/runs/4925721788/jobs/8800292224?pr=214#step:8:40 we probably need a dedicated pull request to appease flake8 first, and then rebase onto latest main after merge.
Collaborator
|
@johanneskastl with pull request #207 merged just now, there is a good chance that flake8 and the CI will be happy after a rebase onto latest |
Contributor
Author
Sure, stay tuned... |
johanneskastl
force-pushed
the
20230509_fix_hardcoded_python3_executable_name
branch
from
0f3962c to
51e758d
Compare
Contributor
Author
|
@hartwork CI looks green, hooray! |
Collaborator
|
@johanneskastl thanks! 👍 |
ssbarnea
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #210