-
-
Notifications
You must be signed in to change notification settings - Fork 82
Remove python3.6 support #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setup.cfg: Change project requirements to python >= 3.7.
@dvzrv we can try a force push with new SHA1s (e.g. by flipping commit order in |
.github/workflows/tox.yml: Remove CI workflows against Python 3.6, as only Python >= 3.7 is supported.
I tried with touching the commit messages, but I guess this is just some weird thing with github actions probably... |
@dvzrv Weird and buggy, yes. Would you be up to try… for i in 1 2 ; do git revert --no-edit HEAD~1 ; done
git push .......with two reverting commits more to see if the CI heals and then try again with the reverts dropped. Just an idea. |
|
PS: @dvzrv the overall diff would be empty then, maybe add some bogus change on top so that GitHub won't close the PR or something. Just thinking aloud... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvzrv first half worked, nice, let's see about the second half…
|
Don't worry about required, I fix that. |
@ssbarnea how? |
|
But I am worried about not seeing any file updated. I was expecting metadata updated and GHA jobs removed. |
|
Okay, but this seems to have fixed it now (I have removed the dummy commit on top). |
hartwork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
@ssbarnea that's from the revert commits put in by @dvzrv in the meantime, see #190 (comment) . |

Remove support for Python 3.6 as it is not supported by upstream anymore.