Skip to content

Conversation

@dvzrv
Copy link
Contributor

@dvzrv dvzrv commented Nov 18, 2022

Remove support for Python 3.6 as it is not supported by upstream anymore.

setup.cfg:
Change project requirements to python >= 3.7.
@dvzrv
Copy link
Contributor Author

dvzrv commented Nov 18, 2022

screenshot-2022-11-18_16-36-30

hmm 🤔

@hartwork hartwork added the enhancement This issue/PR relates to a feature request. label Nov 18, 2022
@hartwork
Copy link
Collaborator

screenshot-2022-11-18_16-36-30

hmm 🤔

@dvzrv we can try a force push with new SHA1s (e.g. by flipping commit order in git rebase -i HEAD~2) or close and re-open of the PR, in hope that GitHub fixes itself about this. What do you think?

.github/workflows/tox.yml:
Remove CI workflows against Python 3.6, as only Python >= 3.7 is
supported.
@dvzrv
Copy link
Contributor Author

dvzrv commented Nov 18, 2022

@dvzrv we can try a force push with new SHA1s (e.g. by flipping commit order in git rebase -i HEAD~2) or close and re-open of the PR, in hope that GitHub fixes itself about this. What do you think?

I tried with touching the commit messages, but I guess this is just some weird thing with github actions probably...

@hartwork
Copy link
Collaborator

@dvzrv we can try a force push with new SHA1s (e.g. by flipping commit order in git rebase -i HEAD~2) or close and re-open of the PR, in hope that GitHub fixes itself about this. What do you think?

I tried with touching the commit messages, but I guess this is just some weird thing with github actions probably...

@dvzrv Weird and buggy, yes. Would you be up to try…

for i in 1 2 ; do git revert --no-edit HEAD~1 ; done
git push .......

with two reverting commits more to see if the CI heals and then try again with the reverts dropped. Just an idea.

@hartwork
Copy link
Collaborator

PS: @dvzrv the overall diff would be empty then, maybe add some bogus change on top so that GitHub won't close the PR or something. Just thinking aloud...

Copy link
Collaborator

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvzrv first half worked, nice, let's see about the second half…

@ssbarnea
Copy link
Member

Don't worry about required, I fix that.

@hartwork
Copy link
Collaborator

Don't worry about required, I fix that.

@ssbarnea how?

@ssbarnea
Copy link
Member

But I am worried about not seeing any file updated. I was expecting metadata updated and GHA jobs removed.

@dvzrv
Copy link
Contributor Author

dvzrv commented Nov 18, 2022

Okay, but this seems to have fixed it now (I have removed the dummy commit on top).

Copy link
Collaborator

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@hartwork hartwork merged commit 84ea106 into pycontribs:main Nov 18, 2022
@hartwork
Copy link
Collaborator

But I am worried about not seeing any file updated. I was expecting metadata updated and GHA jobs removed.

@ssbarnea that's from the revert commits put in by @dvzrv in the meantime, see #190 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This issue/PR relates to a feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants