Upgrade the build process #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Ziegenberg <[email protected]>
…ng PEP 517 pyproject.toml build-requires Signed-off-by: Daniel Ziegenberg <[email protected]>
Member
|
Can you please make this one do only "Update built process" so it changes deps related to built process and update the newer commands in tox.ini. This change should not touch pre-commit config. |
Collaborator
Author
|
Would the following work? I keep e4705ba and e0f9752 as-is and from 894813d I will keep:
Is rebasing and force-pushing ok? Cause I see b829be1 in here. The following will go into a new PR:
|
ssbarnea
requested changes
Oct 25, 2021
ssbarnea
approved these changes
Oct 25, 2021
Collaborator
Author
|
OK. I'll do so tomorrow. Gotta go now |
ssbarnea
changed the title
ziegenberg
force-pushed
the
update-dependencies
branch
from
b829be1 to
e0f9752
Compare
…e an isolated_build Signed-off-by: Daniel Ziegenberg <[email protected]>
Signed-off-by: Daniel Ziegenberg <[email protected]>
Collaborator
Author
ssbarnea
requested changes
Oct 27, 2021
| commands = | ||
| rm -rfv {toxinidir}/dist/ | ||
| python -m pep517.build \ | ||
| --source \ |
Member
There was a problem hiding this comment.
Just remove --sdist and --wheel because they are implicit. If you check the --help section you will realise that running without them is better for testing.
Collaborator
Author
There was a problem hiding this comment.
Ah, you were a bit too quick for me. :)
I'll look into this and resolve it - if necessary - in a new PR
ssbarnea
approved these changes
Oct 27, 2021
ziegenberg
added a commit
to ziegenberg/ansi2html
that referenced
this pull request
Nov 2, 2021
As discussed in PR pycontribs#145 removing the implicit building options as they disable the default behavior. According to the documentation: By default, a source distribution (sdist) is built from {srcdir} and a binary distribution (wheel) is built from the sdist. This is recommended as it will ensure the sdist can be used to build wheels. Pass -s/–sdist and/or -w/–wheel to build a specific distribution. If you do this, the default behavior will be disabled, and all artifacts will be built from {srcdir} (even if you combine -w/–wheel with -s/–sdist, the wheel will be built from {srcdir}). Signed-off-by: Daniel Ziegenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from pep517.build to build because pep517 is deprecated.