Skip to content

Remove unnecessary nose test dependency #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ci/requirements-py3.10.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dependencies:
- ephem
- h5py
# - netcdf4 # pulls in a different version of numpy with ImportError
- nose
# - numba # python 3.9 compat in early 2021
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand Down
1 change: 0 additions & 1 deletion ci/requirements-py3.7-min.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ channels:
- defaults
dependencies:
- coveralls
- nose
- pip
- pytest
- pytest-cov
Expand Down
1 change: 0 additions & 1 deletion ci/requirements-py3.7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dependencies:
- ephem
- h5py
- netcdf4
- nose
- numba
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand Down
1 change: 0 additions & 1 deletion ci/requirements-py3.8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dependencies:
- ephem
- h5py
- netcdf4
- nose
- numba
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand Down
1 change: 0 additions & 1 deletion ci/requirements-py3.9.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dependencies:
- ephem
- h5py
# - netcdf4 # pulls in a different version of numpy with ImportError
- nose
# - numba # python 3.9 compat in early 2021
- numpy >= 1.16.0
- pandas >= 0.25.0
Expand Down
2 changes: 1 addition & 1 deletion docs/sphinx/source/user_guide/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ referred to as *conda environments*, but they're the same for our purposes.
``conda create --name pvlibdev python pandas scipy``
#. **Activate** the new conda environment: ``conda activate pvlibdev``
#. **Install** additional packages into your development environment:
``conda install jupyter ipython matplotlib pytest nose flake8``
``conda install jupyter ipython matplotlib pytest flake8``

The `conda documentation <https://conda.io/docs/index.html>`_ has more
information on how to use conda virtual environments. You can also add
Expand Down
4 changes: 2 additions & 2 deletions docs/sphinx/source/whatsnew/v0.9.5.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ v0.9.5 (anticipated March 2023)
-------------------------------

Starting with this version, new releases are no longer distributed through
the ``pvlib`` `conda channel<https://anaconda.org/pvlib/pvlib>`_. We recommend
the ``pvlib`` `conda channel <https://anaconda.org/pvlib/pvlib>`_. We recommend
``conda`` users install from the ``conda-forge`` channel instead (see
:ref:`installation`).

Expand Down Expand Up @@ -36,7 +36,7 @@ Benchmarking

Requirements
~~~~~~~~~~~~

* Removed unnecessary ``nose`` test requirement (:pull:`1637`)

Contributors
~~~~~~~~~~~~
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
'h5py',
'importlib-metadata; python_version < "3.8"']

TESTS_REQUIRE = ['nose', 'pytest', 'pytest-cov', 'pytest-mock',
TESTS_REQUIRE = ['pytest', 'pytest-cov', 'pytest-mock',
'requests-mock', 'pytest-timeout', 'pytest-rerunfailures',
'pytest-remotedata']
EXTRAS_REQUIRE = {
Expand Down