Remove dylib from atomic linking
#123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dylib` addition breaks static binaries causing them not never be static again, because the atomic lib is always added as a dynamic library. Removing the `dylib` should not be an issue, since the compiler will either add it dynamically or statically based upon the compiler settings.
|
@octavonce could you check this PR please. It currently breaks static builds of Vaultwarden for example. |
|
Also, as a reference, the same happened with rust-openssl sfackler/rust-openssl#2094 |
|
Good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dylibaddition breaks static binaries causing them not never be static again, because the atomic lib is always added as a dynamic library.Removing the
dylibshould not be an issue, since the compiler will either add it dynamically or statically based upon the compiler settings.