Skip to content

Added tryHalogen backend #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added tryHalogen backend #88

wants to merge 1 commit into from

Conversation

sudhirvkumar
Copy link
Contributor

@paf31 Sending you the PR as discussed in IRC

@@ -287,23 +275,29 @@ $(function() {

var scripts = [bundle, wrapped].join("\n");

var script = iframe.createElement('script');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this on other backends? I seem to remember it was important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked every single backend available in try.purescript.org just now... (twice) and everything is working... including Halogen

Copy link
Contributor Author

@sudhirvkumar sudhirvkumar Aug 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that I tested only in Chrome!

EDIT: I tested in Firefox 54 & Opera 47 (all in ubuntu) and it works

@paf31
Copy link
Contributor

paf31 commented Aug 31, 2017

Could you please rebase this? I've added a DEPENDENCIES file which you could regenerate in order to give attribution here.

Thanks!

@sudhirvkumar
Copy link
Contributor Author

@paf31 sure will do

@RAbraham
Copy link

Thanks @sudhirvkumar for working on this. Excited to play with it.

@rintcius
Copy link
Contributor

@sudhirvkumar let me know if you don't have time to finish this. I'm happy to help

@hdgarrood
Copy link
Collaborator

Thanks for the PR, although I'm going to close it as we are now using a different design where different backends are no longer a thing, see #128. Getting Halogen examples working with the new design will now hopefully just be a case of updating the psc-package.json file to include it.

@hdgarrood hdgarrood closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants