-
Notifications
You must be signed in to change notification settings - Fork 50
Fix NPM shim resolver on Firefox #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPM shim resolver on Firefox #290
Conversation
Looks like the import map for import"react";import"object-assign";export{default}from"./cjs/react-dom-server.browser.production.min.js"; I'll investigate. |
Production version will use minified JS.
client/public/frame.html
Outdated
"react": "https://ga.jspm.io/npm:[email protected]/dev.index.js", | ||
"react-dom": "https://ga.jspm.io/npm:[email protected]/dev.index.js", | ||
"react-dom/server": "https://ga.jspm.io/npm:[email protected]/dev.server.browser.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, does bumping the version also fix this? I would think this might need to be in sync with the purescript-react
purescript-react-basic
libraries which were recently updated to 18 (I'm actually surprised that createRoot
is in the dev
version of 16.13.1
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're right. Bumping the React version to 17.0.2
, the last release before 18, makes it work.
@thomashoneyman Can I get a review on this when you get a chance? |
Description of the change
Fixes #289. However, trying to run the React examples from the cookbook get a weird error even with this fix:
HelloReactHooks
ButtonsReactHooks
Checklist: