Skip to content

Add PureScript & Package Set version info #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 18, 2022
Merged

Add PureScript & Package Set version info #280

merged 8 commits into from
Jun 18, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #149. Screenshots below. CI tests (in progress) should prove that checks work:

Normal view:
image

Mobile view:
image


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0 by @)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

Client CI should fail because the purs version is 0.15.3 when it should be 0.15.2. Once that build fails, I'll check again with the package set version differing.

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Jun 18, 2022

Client CI successfully failed with the below error message:

< pursVersion = "v0.15.3"
---
> pursVersion = "v0.15.2"
PureScript and/or package set versions in "client/src/Try/SharedConfig.purs"
do not match the versions extracted from "stack.yaml" and "staging/packages.dhall"
Please run "cd client && npm run updateConfigVersions". CI will fail until then.

Now testing the package set version diff

@JordanMartinez
Copy link
Contributor Author

Package set version CI check successfully failed with the following error:

< packageSetVersion = "0.15.3-20220531"
---
> packageSetVersion = "0.15.2-20220531"
PureScript and/or package set versions in "client/src/Try/SharedConfig.purs"
do not match the versions extracted from "stack.yaml" and "staging/packages.dhall".
Please run "cd client && npm run updateConfigVersions". CI will fail until then.

@JordanMartinez
Copy link
Contributor Author

This PR is ready for review.

@JordanMartinez JordanMartinez merged commit a53e679 into purescript:master Jun 18, 2022
@JordanMartinez JordanMartinez deleted the add-version-info branch June 18, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearly indicate compiler version and package set in use
2 participants