Skip to content

Fix double-encoding of quotation marks #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Fix double-encoding of quotation marks #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef358c2
Fix double-encoding of quotation marks
rhendric Nov 29, 2021
bfa484d
Update CHANGELOG.md
rhendric Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Bugfixes:

Other improvements:
- Update package set to `psc-0.14.5-20211111` (#260 by @JordanMartinez)
- Fix double-encoding of quotation marks (#261 by @rhendric)

## [v2021-11-11.1](https://github.com/purescript/trypurescript/releases/tag/v2021-11-11.1)

Expand Down
2 changes: 1 addition & 1 deletion staging/src/TryPureScript.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ encode :: String -> String
encode =
replaceAll (Pattern "<") (Replacement "&lt;")
<<< replaceAll (Pattern ">") (Replacement "&gt;")
<<< replaceAll (Pattern "&") (Replacement "&amp;")
<<< replaceAll (Pattern "\"") (Replacement "&quot;")
<<< replaceAll (Pattern "&") (Replacement "&amp;") -- must be replaced before all the others!

foreign import withConsoleImpl
:: forall a
Expand Down