Adds longer loading screen #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanMartinez
approved these changes
Sep 22, 2021
| @@ -85,7 +86,9 @@ _editor = SProxy | |||
| loader :: Loader | |||
| loader = makeLoader Config.loaderUrl | |||
|
|
|||
| foreign import setupIFrame :: EffectFn1 (Object JS) Unit | |||
| type LoadCb = Effect Unit | |||
| type FailCb = Effect Unit | |||
There was a problem hiding this comment.
I don't think these type aliases are needed, but 🤷
There was a problem hiding this comment.
I'm OK with them in this case because it can be otherwise difficult to tell which is the 'load' callback and which is the 'fail' callback. In other projects I also use records to help, ie. { fail :: Effect Unit, load :: Effect Unit }.
|
@mikesol Could you add an entry to the changelog file? |
thomashoneyman
approved these changes
Sep 22, 2021
thomashoneyman
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Keeps the loader up longer, lowering blank-screen time to less than 50ms.
Checklist: