Skip to content

Fix encode only replacing first occurrences #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2021
Merged

Fix encode only replacing first occurrences #254

merged 2 commits into from
Sep 12, 2021

Conversation

jy14898
Copy link
Contributor

@jy14898 jy14898 commented Sep 11, 2021 •
edited
Loading

Fixes "text try.purescript.org?github=/<owner>/<repo>/<branch or tag>/<file>.purs" being shown as try.purescript.org?github=/<owner>///.purs in the main example

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0 by @)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@jy14898 jy14898 marked this pull request as ready for review September 11, 2021 13:39
thomashoneyman
thomashoneyman approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomashoneyman thomashoneyman merged commit 8cb2ffb into purescript:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jy14898 @thomashoneyman