Frontend updates for 0.12 #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to work overall. Calling the API and compiling works, however the iframe is yielding a |
|
I think that is because of the |
|
The client is now working as expected. |
Merged
hdgarrood
reviewed
Feb 25, 2019
| @@ -211,7 +211,7 @@ execute js bundle bc@(BackendConfig backend) = do | |||
| ] | |||
|
|
|||
| replaced = replace' (unsafeRegex """require\("[^"]*"\)""" global) (\s _ -> | |||
| "PS['" <> String.drop 12 (String.take (String.length s - 2) s) <> "']") (unwrap js) | |||
| "PS['" <> String.drop 12 (String.take (String.length s - 11) s) <> "']") (unwrap js) | |||
There was a problem hiding this comment.
Bit of a nit but can we do something like s # String.split (String.Pattern "/") # Array.index 1 here instead? That should be more robust to these sorts of changes (if this ever changes again) and it's also a little clearer, I think.
|
Resolved by #135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.