Skip to content

unselectable prop causes runtime warnings #33

Open
@ntwilson

Description

@ntwilson

When I make a table with unselectable: true, I get a warning from React:

Warning: Received true for a non-boolean attribute unselectable.
If you want to write it to the DOM, pass a string instead: unselectable="true" or unselectable={value.toString()}.

I'm using React & React-DOM v 17.0.2.

Would you consider changing unselectable to String? Or is there a reason that I should ignore the warning from React? It does appear that unselectable: true works, but unselectable: false doesn't. I'm guessing if the unselectable prop is present at all, it just sets it to not be selectable, despite the value you give it.
If the warning should be ignored, maybe you could consider changing unselectable to Unit, so it's more clear that it's mere presence is what affects the behavior?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions