-
Notifications
You must be signed in to change notification settings - Fork 6
Update according to Contributors library guidelines #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update according to Contributors library guidelines #9
Conversation
README.md
Outdated
`http-methods` documentation is stored in a few places: | ||
|
||
1. Module documentation is [published on Pursuit](https://pursuit.purescript.org/packages/purescript-http-methods). | ||
2. Written documentation and [the changelog](./docs/CHANGELOG.md) are kept in [the docs directory](./docs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's not much reason for a documentation directory we could perhaps just remove them and treat this as a special case. Perhaps we could add to the library summary the RFCs this is based on (HTTP/1.1 with RFC 2518 and RFC 5789)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm up for removing the docs
repo, but we would need to move the CHANGELOG.md
file into the root folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we do need to move the CHANGELOG and the CONTRIBUTING files into the repository root. When doing that, we could remove this line altogether (because there won't be a docs directory anymore). Remember that we'll also need to fix the CONTRIBUTING link later in the README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leaving CONTRIBUTING.MD
in the .github
folder is a valid choice based on GH's help page. Whether we want to leave it there or move it to the root folder is a separate matter.
I think moving it to the root folder is better as it increases visibility of it.
.github/CONTRIBUTING.md
Outdated
@@ -0,0 +1,5 @@ | |||
# Contributing to HTTP Methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind moving this into the root of the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
README.md
Outdated
|
||
1. If you encounter a problem or have a question, please [open an issue](https://github.com/purescript-contrib/purescript-http-methods/issues). We'll do our best to work with you to resolve or answer it. | ||
|
||
2. If you would like to contribute code, tests, or documentation, please [read the contributor guide](./.github/CONTRIBUTING.md). It's a short, helpful introduction to contributing to this library, including development instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update this link to point at ./CONTRIBUTING.md
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
This pull request is part of an effort to update and standardize the Contributors libraries according to the Library Guidelines. Specifically, it:
test
directory.This PR is the groundwork for followup efforts to ensure contributor libraries are kept up-to-date, documented, tested, and accessible to users and new contributors.
Note: I don't think this repo needs any further docs, tests, or quick start guide. The source code and resulting documentation is pretty clear as is.