Skip to content

Conversation

@SHAcollision
Copy link
Collaborator

Latest pubky-core conflicts in version of bytes with axum 0.7.9 . This can be fixed by upgrading to axum 0.8.0 which required:

  1. Bumping utoipa to latest commit in main.
  2. Do the same in pubky-app-specs repo.
  3. Changing how params in endpoints are prefixed. Axum 0.8 changes :param to {param} so our macro for swagger/axum is not needed anymore.

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

  • Testing: Implement and pass new tests for the new features/fixes, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@SHAcollision SHAcollision merged commit b7832c5 into main Jan 7, 2025
3 checks passed
@SHAcollision SHAcollision deleted the deps/axum branch February 12, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants