fix(sdk): null rust pointer error on authflow #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SHAcollision
force-pushed
the
fix/rust-pointer-errors
branch
from
64049b5 to
284576f
Compare
SHAcollision
force-pushed
the
fix/rust-pointer-errors
branch
3 times, most recently
from
c5b1b5d to
cc1423a
Compare
SHAcollision
force-pushed
the
fix/rust-pointer-errors
branch
from
cc1423a to
b5c29e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First added some MRE (as tests) for panicking the wasm runtime from the JS caller in several where it could panic on the AuthFlow.
Guarded the JS AuthFlow wrapper with shared state and client-state errors so repeat awaits or polling after completion no longer trigger WASM null pointer panics.
Unrelated by needed: Documented the Rust and JS pattern for reusing a shared/global Pubky facade instead of recreating it per request.
After merging the lastes from
mainfigured out a small bug as well: