Docs/improvements #271
Open
Docs/improvements #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dzdidi <[email protected]>
Signed-off-by: dzdidi <[email protected]>
- fix readme typo - check if wasm-pack is installed Signed-off-by: dzdidi <[email protected]>
Signed-off-by: dzdidi <[email protected]>
Signed-off-by: dzdidi <[email protected]>
Collaborator
SeverinAlexB
left a comment
SeverinAlexB
left a comment
There was a problem hiding this comment.
Do we really need the user in this doc? Does it make the docs clearer? Is having an "Authenticator" not good enough already?
| 1. **Capabilities**: A list of strings specifying scopes and the actions that can be performed on them. | ||
| 1. **HTTP relay**: An independent HTTP relay (or the backend of the 3rd Party App) forwarding the [`AuthToken`](#authtoken-encoding) to the frontend. | ||
| ### glossary | ||
| 1. **User**: an entity owner of secret and public key and owner of assets which can be accessed on location identified by their public key. |
Collaborator
There was a problem hiding this comment.
Do we need to add the user here? Not sure this makes the docs clearer?
Contributor
Author
There was a problem hiding this comment.
IMHO as long as it does not add to confusion it is OK to have overly verbose docs
Co-authored-by: Severin Alexander Bühler <[email protected]>
Signed-off-by: dzdidi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially was done in scope of #242
Moving to stand alone pr now