-
Notifications
You must be signed in to change notification settings - Fork 6
chore: add new validation rules #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tipogi
wants to merge
8
commits into
main
Choose a base branch
from
feat/validation-pattern
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch-21
reviewed
Dec 4, 2025
catch-21
reviewed
Dec 4, 2025
Contributor
Author
|
Thanks @catch-21 for the help! |
ok300
reviewed
Dec 7, 2025
Contributor
|
I think this fixes #35 |
ok300
reviewed
Dec 7, 2025
ok300
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive validation rules across all data models, refactors constants organization, and separates sanitization from validation logic.
Key Changes
Code Organization
src/constants.rsto centralize all constantsValidation Enhancements
Tags:
sanitize_tag_label()andvalidate_tag_label()functionsPubkyAppTagandPubkyAppFeedFeeds:
Posts:
pubky://,http://,https://,ipfs://,ipns://[DELETED]contentUsers:
Sanitization vs Validation
Problems Solved
Files Changed
src/constants.rs(new) - Centralized constantssrc/models/tag.rs- Reusable validation functionssrc/models/feed.rs- Tag validationsrc/models/post.rs- Attachment & content validationsrc/models/user.rs- Enhanced field validationsrc/models/blob.rs,file.rs- Test improvementssrc/common.rs,lib.rs,utils.rs,uri_parser.rs- Import updatesImpact
✅ Better data integrity | ✅ Clearer error messages | ✅ Reusable validation functions | ✅ Comprehensive tests