-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Shwartz Diamond filling surface #14633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
static constexpr float CorrectionAngle = -45.; | ||
|
||
// Density adjustment to have a good %of weight. | ||
static constexpr double DensityAdjust = 2.44; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just implemented your code in Orca Slicer and works great, for this infill Density Adjust = 2.1 is more precise.
static constexpr double Density Adjust = 2.1;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RF47 , cool :)
and thanks for the tip regarding the density adjustment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also changed paterntolerance to 0.1, it produces smoother curves without affecting performance too much.
You need to be more expressive about changes you're doing when you make PRs to public projects. As of now, it's just a dump of weird math. Add some simple explanation of whatever is "Schwartz Diamond", why it's good and why you decided to add it. |
Some references on Schwartz D:
Slightly faster to print than Gyroid with similar mechanical properties, but uses more material. |
FKS may be more interesting to explore. It can be approximated as: See https://github.com/jedisct1/fischer-koch-s ![]() |
|
No description provided.