Skip to content

Conversation

maxim1000
Copy link

No description provided.

static constexpr float CorrectionAngle = -45.;

// Density adjustment to have a good %of weight.
static constexpr double DensityAdjust = 2.44;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just implemented your code in Orca Slicer and works great, for this infill Density Adjust = 2.1 is more precise.
static constexpr double Density Adjust = 2.1;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RF47 , cool :)
and thanks for the tip regarding the density adjustment

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed paterntolerance to 0.1, it produces smoother curves without affecting performance too much.

@gudvinr
Copy link

gudvinr commented Jul 13, 2025

You need to be more expressive about changes you're doing when you make PRs to public projects. As of now, it's just a dump of weird math.

Add some simple explanation of whatever is "Schwartz Diamond", why it's good and why you decided to add it.
Throw in some pictures, references to research papers, etc.

@jedisct1
Copy link

jedisct1 commented Aug 6, 2025

Some references on Schwartz D:

Slightly faster to print than Gyroid with similar mechanical properties, but uses more material.

@jedisct1
Copy link

jedisct1 commented Aug 6, 2025

FKS may be more interesting to explore.

It can be approximated as:

$\cos(2x) \cdot \sin(y) \cdot \cos(z) + \cos(2y) \cdot \sin(z) \cdot \cos(x) + \cos(2z) \cdot \sin(x) \cdot \cos(y) = 0$

See https://github.com/jedisct1/fischer-koch-s

fischer_koch_s

@RF47
Copy link

RF47 commented Aug 9, 2025

FKS may be more interesting to explore.

It can be approximated as:

cos ⁡ ( 2 x ) ⋅ sin ⁡ ( y ) ⋅ cos ⁡ ( z ) + cos ⁡ ( 2 y ) ⋅ sin ⁡ ( z ) ⋅ cos ⁡ ( x ) + cos ⁡ ( 2 z ) ⋅ sin ⁡ ( x ) ⋅ cos ⁡ ( y ) = 0

See https://github.com/jedisct1/fischer-koch-s

fischer_koch_s

SoftFever/OrcaSlicer#10360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants