Allow RootContext to create child contexts for streams. #34

dgn · 2020-08-21T12:12:21Z

To fix #6

Without this, it's impossible (or just incredibly hard, I tried for hours) to read filter config from within an HttpContext or StreamContext. It requires users to always supply a RootContext, which adds a bit of boilerplate, but IMO is a reasonable way to connect RootContext with its children in Rust, as there's no easy way to manage global state.

I'm still very new to Rust so this might be the wrong way to do it. Let's discuss.

src/dispatcher.rs

src/traits.rs

PiotrSikora · 2020-11-14T11:10:06Z

src/traits.rs

+    fn create_http_context(&self, _context_id: u32, _root_context_id: u32) -> Box<dyn HttpContext> {
+        Box::new(EmptyHttpContext)
+    }
+
+    fn create_stream_context(
+        &self,
+        _context_id: u32,
+        _root_context_id: u32,
+    ) -> Box<dyn StreamContext> {
+        Box::new(EmptyStreamContext)
+    }
+
+    fn get_type(&self) -> ContextType {
+        ContextType::RootContext
+    }


Since we know the context type, could this be turned into a single new_context function that returns various context types?

Alternatively, we could allow plugins to implement multiple traits/interfaces, in which case get_type would be an unnecessary limitation, although I don't think this could work with the current ABI...

if I had to choose I'd prefer the former (ie have a single new_context fn that creates whatever type), but at this point I think I like the more explicit approach more- because in the end we would have to be type-casting in the SDK again to call trait-specific fn's. but I'm open to suggestions

PiotrSikora · 2020-11-16T20:05:21Z

examples/http_body.rs

+    }
+}
+
+impl Context for HttpBodyRoot {}


Nit: move impl Context before impl RootContext to match order for HttpBody.

src/traits.rs

PiotrSikora · 2020-11-16T20:14:02Z

examples/http_auth_random.rs

@@ -20,10 +20,23 @@ use std::time::Duration;
 #[no_mangle]
 pub fn _start() {
    proxy_wasm::set_log_level(LogLevel::Trace);
-    proxy_wasm::set_http_context(|_, _| -> Box<dyn HttpContext> { Box::new(HttpAuthRandom) });
+    proxy_wasm::set_root_context(|_| -> Box<dyn RootContext> { Box::new(HttpAuthRandomRoot) });


Looking at this example, I wonder if we couldn't do something type-specific here, e.g.

proxy_wasm::set_root_context(|_| -> Box<dyn RootContext> { Box::new(HttpHeadersRoot) }); proxy_wasm::set_http_context(|root_context, context_id| -> Box<dyn HttpContext> { root_context.new_http_context(context_id) });

with dispatcher taking care of resolving root_context_id to root_context before calling this callback?

On the second thought, that might be useless, since we cannot expose multiple interfaces right now anyway.

PiotrSikora

Also, could you merge/rebase on top of current master branch? Thanks!

Signed-off-by: Daniel Grimm <[email protected]>

- Remove root_context_id from RootContext's create_http_stream and create_http_context calls - Move EmptyHttpContext after HttpContext declaration - Reorder trait impl's in examples to be consistent Signed-off-by: Daniel Grimm <[email protected]>

PiotrSikora

Thanks! Could you also add an example showing developers how to use this feature? Maybe add a new header which value is passed via configuration to examples/http_headers.rs?

Note to self: merge this after tagging v0.1.3 (pending fix for #40).

src/traits.rs

examples/http_auth_random.rs

PiotrSikora · 2020-11-18T00:30:28Z

examples/http_body.rs

@@ -18,10 +18,23 @@ use proxy_wasm::types::*;
 #[no_mangle]
 pub fn _start() {
    proxy_wasm::set_log_level(LogLevel::Trace);
-    proxy_wasm::set_http_context(|_, _| -> Box<dyn HttpContext> { Box::new(HttpBody) });
+    proxy_wasm::set_root_context(|_| -> Box<dyn RootContext> { Box::new(HttpBodyRoot) });
 }

 struct HttpBody;


Nit: move struct HttpBody; after definition of HttpBodyRoot.

PiotrSikora · 2020-11-18T03:53:45Z

src/types.rs

@@ -85,3 +85,9 @@ pub enum MetricType {
 }

 pub type Bytes = Vec<u8>;
+
+pub enum ContextType {


Please add:

#[repr(u32)] #[derive(Debug)]

(it's not used in the ABI right now, but it's going to be soon, so we might as well define it properly now)

Also, could you move it below Status?

PiotrSikora · 2020-11-18T05:06:51Z

src/dispatcher.rs

+                    self.create_stream_context(context_id, root_context_id)
+                }
+                ContextType::RootContext => panic!("missing ContextType on root_context"),
+            }


One more thing. I think it would be useful if we could retain backwards compatibility, and merge this without breaking all existing plugins, even if there aren't too many in the wild right now.

One way to do this is to fallback to the standalone constructors in case root_context.get_type() returns ContextType::RootContext or None, and perhaps revert changes to examples/http_auth_random.rs to make sure that the old code path still works.

+1 to remain backwards-compatible, but I think we should then deprecate the old way to create contexts and remove it in 0.2.0

that would also allow us to remove NoopRoot in 0.2.0

The "old way" is fine for plugins that don't have configuration (e.g. where everything is already in the code), and the "new way" can double the code size with unnecessary boilerplate.

But it's something to consider for sure.

PiotrSikora · 2020-11-18T05:10:47Z

src/traits.rs

@@ -121,6 +121,18 @@ pub trait RootContext: Context {
    fn on_queue_ready(&mut self, _queue_id: u32) {}

    fn on_log(&mut self) {}
+
+    fn create_http_context(&self, _context_id: u32) -> Box<dyn HttpContext> {
+        Box::new(EmptyHttpContext)


Box<dyn HttpContext> -> Option<Box<dyn HttpContext>> and return None.

PiotrSikora · 2020-11-18T05:10:54Z

src/traits.rs

+    }
+
+    fn create_stream_context(&self, _context_id: u32) -> Box<dyn StreamContext> {
+        Box::new(EmptyStreamContext)


PiotrSikora · 2020-11-18T05:11:38Z

src/traits.rs

+    }
+
+    fn get_type(&self) -> ContextType {
+        ContextType::RootContext


Option<ContextType> and return None.

PiotrSikora · 2020-11-18T05:12:04Z

src/traits.rs

+struct EmptyStreamContext;
+
+impl StreamContext for EmptyStreamContext {}
+impl Context for EmptyStreamContext {}


This won't be needed with Option<T>.

PiotrSikora · 2020-11-18T05:12:15Z

src/traits.rs

+struct EmptyHttpContext;
+
+impl HttpContext for EmptyHttpContext {}
+impl Context for EmptyHttpContext {}


This won't be needed with Option<T>.

- consistent ordering of struct defs in examples - attributes for ContextType enum Signed-off-by: Daniel Grimm <[email protected]>

Signed-off-by: Daniel Grimm <[email protected]>

examples/http_config.rs

PiotrSikora · 2020-11-20T09:54:18Z

examples/http_config.rs

+    proxy_wasm::set_log_level(LogLevel::Trace);
+    proxy_wasm::set_root_context(|_| -> Box<dyn RootContext> {
+        Box::new(HttpConfigHeaderRootContext {
+            header_content: "".to_string(),


header_content: String::new(),

but you could also use:

header_context: None,

if you change header_content into Option<String>.

examples/http_config.rs

PiotrSikora · 2020-11-20T10:00:29Z

examples/http_config.rs

+    }
+}
+
+struct HttpConfigHeaderRootContext {


Nit: name this HttpConfigHeaderRoot and move it before HttpConfigHeader to match style used in other examples.

examples/http_auth_random.rs

PiotrSikora · 2020-11-20T10:21:39Z

examples/http_config.rs

+
+    fn create_http_context(&self, _context_id: u32) -> Option<Box<dyn HttpContext>> {
+        Some(Box::new(HttpConfigHeader {
+            header_content: self.header_content.clone(),


This seems expensive, since presumably each context will own a copy of the header value.

It's fine in this example, since the value is small, but in general, wouldn't it be better to store a reference to the parent context and access configuration from there?

PiotrSikora · 2020-11-20T10:25:16Z

src/dispatcher.rs

+                    self.create_stream_context(context_id, root_context_id)
+                }
+                ContextType::RootContext => panic!("missing ContextType on root_context"),
+            }


The "old way" is fine for plugins that don't have configuration (e.g. where everything is already in the code), and the "new way" can double the code size with unnecessary boilerplate.

But it's something to consider for sure.

PiotrSikora · 2020-11-20T10:26:59Z

src/types.rs

+#[repr(u32)]
+#[derive(Debug)]
+pub enum ContextType {
+    HttpContext = 0,


Could you re-add RootContext as 0 here? Thanks.

Why? How would that be different from returning None?

I meant only adding enum value here, not using it in this PR, since the ContextType is part of the updated ABI and I wanted to avoid renumbering later... But since it's not transmitted over the ABI boundary, it probably doesn't matter too much.

Signed-off-by: Daniel Grimm <[email protected]>

PiotrSikora · 2020-11-20T22:47:05Z

src/types.rs

+#[repr(u32)]
+#[derive(Debug)]
+pub enum ContextType {
+    HttpContext = 0,


I meant only adding enum value here, not using it in this PR, since the ContextType is part of the updated ABI and I wanted to avoid renumbering later... But since it's not transmitted over the ABI boundary, it probably doesn't matter too much.

Fixes yskopets#6. Signed-off-by: Daniel Grimm <[email protected]>

* Use Rust toolchains with working components. (#16) Signed-off-by: Piotr Sikora <[email protected]> * Split licenses check into a separate test target. (#17) Signed-off-by: Piotr Sikora <[email protected]> * Help other developers get started using this SDK. (#15) Signed-off-by: DazWilkin <[email protected]> * Add Bazel support. (#18) Signed-off-by: Shikugawa <[email protected]> Signed-off-by: Piotr Sikora <[email protected]> * Add support for setting HTTP bodies. (#2) Signed-off-by: Gregory Brail <[email protected]> * Release v0.1.1. (#20) Signed-off-by: Piotr Sikora <[email protected]> * Update MapType values to match updated Proxy-Wasm ABI v0.1.0. (#7) Signed-off-by: Yaroslav Skopets <[email protected]> * Release v0.1.2. (#21) Signed-off-by: Piotr Sikora <[email protected]> * Update hashbrown to v0.8.2. (#22) Signed-off-by: Piotr Sikora <[email protected]> * Add cargo audit and cargo outdated checks. (#23) Signed-off-by: Piotr Sikora <[email protected]> * Update chrono to v0.4.15. (proxy-wasm#33) Signed-off-by: Piotr Sikora <[email protected]> * Move optional checks to the end. (proxy-wasm#28) While there, align style with the test framework. Signed-off-by: Piotr Sikora <[email protected]> * Move Bazel to //bazel. (proxy-wasm#29) Signed-off-by: Piotr Sikora <[email protected]> * Fix HTTP body example. (proxy-wasm#32) Signed-off-by: Piotr Sikora <[email protected]> * Add support for setting network buffers. (proxy-wasm#31) Signed-off-by: Piotr Sikora <[email protected]> * Add metrics. (proxy-wasm#30) Fixes #4. Signed-off-by: Piotr Sikora <[email protected]> * Update hashbrown and transitive dependencies. (proxy-wasm#45) Signed-off-by: Piotr Sikora <[email protected]> * Allow building for wasm32-wasi target. (proxy-wasm#42) Signed-off-by: Piotr Sikora <[email protected]> * Make wee-alloc an optional feature. (proxy-wasm#38) Signed-off-by: Yuval Kohavi <[email protected]> * Update rules_rust to latest. (proxy-wasm#46) Signed-off-by: Piotr Sikora <[email protected]> * Update cargo-raze to latest and regenerate artifacts. (proxy-wasm#47) Signed-off-by: Piotr Sikora <[email protected]> * Allow building for wasm32-wasi target using Bazel. (proxy-wasm#50) While there, update Bazel to 3.7.0. Signed-off-by: Piotr Sikora <[email protected]> * Show getrandom and chrono/time usage in examples. (proxy-wasm#51) Signed-off-by: Piotr Sikora <[email protected]> * Use cargo-raze's gen_buildrs for trusted crates. (proxy-wasm#53) Signed-off-by: Piotr Sikora <[email protected]> * Add support for nested HTTP callouts. (proxy-wasm#56) Signed-off-by: Svetlin Zarev <[email protected]> * Allow RootContext to create child contexts for streams. (proxy-wasm#34) Fixes #6. Signed-off-by: Daniel Grimm <[email protected]> * Fix warnings from Clippy v1.50.0 (nightly). (proxy-wasm#58) Signed-off-by: Piotr Sikora <[email protected]> * Release v0.1.3. (proxy-wasm#59) Signed-off-by: Piotr Sikora <[email protected]> * Cleanup instructions for updating dependencies. (proxy-wasm#60) Signed-off-by: Piotr Sikora <[email protected]> * Cleanup WORKSPACE. (proxy-wasm#61) Signed-off-by: Piotr Sikora <[email protected]> * Cleanup examples. (proxy-wasm#62) Signed-off-by: Piotr Sikora <[email protected]> * Update libc (transitive dependency) to v0.2.81. (proxy-wasm#63) Signed-off-by: Piotr Sikora <[email protected]> * Update the declared ABI version to 0.2.0 Signed-off-by: Takaya Saeki <[email protected]> * Update the examples so that they use the latest API Signed-off-by: Takaya Saeki <[email protected]> * Remove ChildContext for now, which is not used anymore Signed-off-by: Takaya Saeki <[email protected]> * Bump the version to 0.0.8 Signed-off-by: Takaya Saeki <[email protected]> * Fix bazel build for the fork's crate Signed-off-by: Takaya Saeki <[email protected]> * Fix clippy erros in bytestring.rs Signed-off-by: Takaya Saeki <[email protected]> * Update dependencies Signed-off-by: Takaya Saeki <[email protected]> * Fix Cargo.toml Signed-off-by: Takaya Saeki <[email protected]> * outdated should check only root deps Signed-off-by: Takaya Saeki <[email protected]> * Fix inconsistent derived traits Signed-off-by: Takaya Saeki <[email protected]> Co-authored-by: Piotr Sikora <[email protected]> Co-authored-by: Daz Wilkin <[email protected]> Co-authored-by: Greg Brail <[email protected]> Co-authored-by: Yaroslav Skopets <[email protected]> Co-authored-by: Yuval Kohavi <[email protected]> Co-authored-by: SvetlinZarev-SAP <[email protected]> Co-authored-by: Daniel Grimm <[email protected]>

This is kind of an improvement from #93 in favor of proxy-wasm/proxy-wasm-rust-sdk#34 and proxy-wasm/proxy-wasm-rust-sdk#67 Note that this is a breaking change, though the fix is trivial. Signed-off-by: Takeshi Yoneda [email protected]

…opets#19) * Use Rust toolchains with working components. (yskopets#16) Signed-off-by: Piotr Sikora <[email protected]> * Split licenses check into a separate test target. (yskopets#17) Signed-off-by: Piotr Sikora <[email protected]> * Help other developers get started using this SDK. (yskopets#15) Signed-off-by: DazWilkin <[email protected]> * Add Bazel support. (yskopets#18) Signed-off-by: Shikugawa <[email protected]> Signed-off-by: Piotr Sikora <[email protected]> * Add support for setting HTTP bodies. (yskopets#2) Signed-off-by: Gregory Brail <[email protected]> * Release v0.1.1. (yskopets#20) Signed-off-by: Piotr Sikora <[email protected]> * Update MapType values to match updated Proxy-Wasm ABI v0.1.0. (yskopets#7) Signed-off-by: Yaroslav Skopets <[email protected]> * Release v0.1.2. (yskopets#21) Signed-off-by: Piotr Sikora <[email protected]> * Update hashbrown to v0.8.2. (yskopets#22) Signed-off-by: Piotr Sikora <[email protected]> * Add cargo audit and cargo outdated checks. (yskopets#23) Signed-off-by: Piotr Sikora <[email protected]> * Update chrono to v0.4.15. (proxy-wasm#33) Signed-off-by: Piotr Sikora <[email protected]> * Move optional checks to the end. (proxy-wasm#28) While there, align style with the test framework. Signed-off-by: Piotr Sikora <[email protected]> * Move Bazel to //bazel. (proxy-wasm#29) Signed-off-by: Piotr Sikora <[email protected]> * Fix HTTP body example. (proxy-wasm#32) Signed-off-by: Piotr Sikora <[email protected]> * Add support for setting network buffers. (proxy-wasm#31) Signed-off-by: Piotr Sikora <[email protected]> * Add metrics. (proxy-wasm#30) Fixes yskopets#4. Signed-off-by: Piotr Sikora <[email protected]> * Update hashbrown and transitive dependencies. (proxy-wasm#45) Signed-off-by: Piotr Sikora <[email protected]> * Allow building for wasm32-wasi target. (proxy-wasm#42) Signed-off-by: Piotr Sikora <[email protected]> * Make wee-alloc an optional feature. (proxy-wasm#38) Signed-off-by: Yuval Kohavi <[email protected]> * Update rules_rust to latest. (proxy-wasm#46) Signed-off-by: Piotr Sikora <[email protected]> * Update cargo-raze to latest and regenerate artifacts. (proxy-wasm#47) Signed-off-by: Piotr Sikora <[email protected]> * Allow building for wasm32-wasi target using Bazel. (proxy-wasm#50) While there, update Bazel to 3.7.0. Signed-off-by: Piotr Sikora <[email protected]> * Show getrandom and chrono/time usage in examples. (proxy-wasm#51) Signed-off-by: Piotr Sikora <[email protected]> * Use cargo-raze's gen_buildrs for trusted crates. (proxy-wasm#53) Signed-off-by: Piotr Sikora <[email protected]> * Add support for nested HTTP callouts. (proxy-wasm#56) Signed-off-by: Svetlin Zarev <[email protected]> * Allow RootContext to create child contexts for streams. (proxy-wasm#34) Fixes yskopets#6. Signed-off-by: Daniel Grimm <[email protected]> * Fix warnings from Clippy v1.50.0 (nightly). (proxy-wasm#58) Signed-off-by: Piotr Sikora <[email protected]> * Release v0.1.3. (proxy-wasm#59) Signed-off-by: Piotr Sikora <[email protected]> * Cleanup instructions for updating dependencies. (proxy-wasm#60) Signed-off-by: Piotr Sikora <[email protected]> * Cleanup WORKSPACE. (proxy-wasm#61) Signed-off-by: Piotr Sikora <[email protected]> * Cleanup examples. (proxy-wasm#62) Signed-off-by: Piotr Sikora <[email protected]> * Update libc (transitive dependency) to v0.2.81. (proxy-wasm#63) Signed-off-by: Piotr Sikora <[email protected]> * Update the declared ABI version to 0.2.0 Signed-off-by: Takaya Saeki <[email protected]> * Update the examples so that they use the latest API Signed-off-by: Takaya Saeki <[email protected]> * Remove ChildContext for now, which is not used anymore Signed-off-by: Takaya Saeki <[email protected]> * Bump the version to 0.0.8 Signed-off-by: Takaya Saeki <[email protected]> * Fix bazel build for the fork's crate Signed-off-by: Takaya Saeki <[email protected]> * Fix clippy erros in bytestring.rs Signed-off-by: Takaya Saeki <[email protected]> * Update dependencies Signed-off-by: Takaya Saeki <[email protected]> * Fix Cargo.toml Signed-off-by: Takaya Saeki <[email protected]> * outdated should check only root deps Signed-off-by: Takaya Saeki <[email protected]> * Fix inconsistent derived traits Signed-off-by: Takaya Saeki <[email protected]> Co-authored-by: Piotr Sikora <[email protected]> Co-authored-by: Daz Wilkin <[email protected]> Co-authored-by: Greg Brail <[email protected]> Co-authored-by: Yaroslav Skopets <[email protected]> Co-authored-by: Yuval Kohavi <[email protected]> Co-authored-by: SvetlinZarev-SAP <[email protected]> Co-authored-by: Daniel Grimm <[email protected]>

Signed-off-by: Kit Chan <[email protected]>

dgn requested a review from PiotrSikora as a code owner August 21, 2020 12:12

dgn force-pushed the master branch 4 times, most recently from 3b1b730 to fa8512a Compare August 21, 2020 13:47

PiotrSikora requested changes Nov 15, 2020

View reviewed changes

dgn force-pushed the master branch from 19813dd to f22f308 Compare November 16, 2020 15:31

PiotrSikora requested changes Nov 16, 2020

View reviewed changes

PiotrSikora reviewed Nov 16, 2020

View reviewed changes

dgn added 2 commits November 17, 2020 09:45

Move context creation to fn of RootContext instead of callback

28ba351

Signed-off-by: Daniel Grimm <[email protected]>

Make rustfmt happy

94ecd03

Signed-off-by: Daniel Grimm <[email protected]>

dgn closed this Nov 17, 2020

dgn force-pushed the master branch from f22f308 to 4cb2db7 Compare November 17, 2020 08:45

dgn reopened this Nov 17, 2020

Addressing review comments

1cad709

- Remove root_context_id from RootContext's create_http_stream and create_http_context calls - Move EmptyHttpContext after HttpContext declaration - Reorder trait impl's in examples to be consistent Signed-off-by: Daniel Grimm <[email protected]>

dgn force-pushed the master branch from 7cf6123 to 1cad709 Compare November 17, 2020 08:55

PiotrSikora reviewed Nov 18, 2020

View reviewed changes

PiotrSikora requested changes Nov 18, 2020

View reviewed changes

dgn force-pushed the master branch 2 times, most recently from 4fc15fc to 05d21f3 Compare November 20, 2020 09:23

dgn added 4 commits November 20, 2020 10:40

React to review comments

6488b8a

- consistent ordering of struct defs in examples - attributes for ContextType enum Signed-off-by: Daniel Grimm <[email protected]>

Add examples/http_config.rs

79e8621

Signed-off-by: Daniel Grimm <[email protected]>

Add backwards compatibility, use Option<> where appropriate

5f0302c

Signed-off-by: Daniel Grimm <[email protected]>

rustfmt

9756371

Signed-off-by: Daniel Grimm <[email protected]>

dgn force-pushed the master branch from 3fe4475 to 9756371 Compare November 20, 2020 09:40

PiotrSikora reviewed Nov 20, 2020

View reviewed changes

Revert unnecessary change in http_auth_random.rs, use String

46cf563

Signed-off-by: Daniel Grimm <[email protected]>

PiotrSikora approved these changes Dec 4, 2020

View reviewed changes

Merge branch 'master' into master

a4658e8

PiotrSikora changed the title ~~Move context creation to fn of RootContext instead of callback~~ Allow RootContext to create child contexts. Dec 4, 2020

PiotrSikora changed the title ~~Allow RootContext to create child contexts.~~ Allow RootContext to create child contexts for streams. Dec 4, 2020

PiotrSikora merged commit 7de2acd into proxy-wasm:master Dec 4, 2020

nullpo-head mentioned this pull request Feb 2, 2021

Update the ABI to version 0.2.0 so that it works with Envoy 1.17 yskopets/proxy-wasm-rust-sdk#19

Merged

PiotrSikora mentioned this pull request Feb 26, 2021

Introduce on_create_child_context hook for creating non root contexts #67

Open

nullpo-head pushed a commit to nullpo-head/proxy-wasm-rust-sdk that referenced this pull request Mar 2, 2021

Allow RootContext to create child contexts for streams. (proxy-wasm#34)

7c28004

Fixes yskopets#6. Signed-off-by: Daniel Grimm <[email protected]>

mathetake mentioned this pull request Mar 9, 2021

Have NewStreamContext and NewHttpContext in RootContext tetratelabs/proxy-wasm-go-sdk#128

Merged

PiotrSikora pushed a commit to PiotrSikora/proxy-wasm-rust-sdk that referenced this pull request Jul 4, 2023

Update link to ATS official Proxy-Wasm plugin. (proxy-wasm#34)

442687b

Signed-off-by: Kit Chan <[email protected]>

Allow RootContext to create child contexts for streams. #34

Allow RootContext to create child contexts for streams. #34

Uh oh!

Conversation

dgn commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiotrSikora left a comment

Choose a reason for hiding this comment

Uh oh!

PiotrSikora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

dgn commented Aug 21, 2020 •

edited

Loading