Skip to content

v8: fix build with GCC. #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2023
Merged

v8: fix build with GCC. #343

merged 5 commits into from
Apr 28, 2023

Conversation

martijneken
Copy link
Contributor

No description provided.

PiotrSikora
PiotrSikora reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the CI with hermetic_cc_toolchain before merging anything.

@PiotrSikora
Copy link
Member

Looks good, but you need to fix the DCO bot (the Signed-off-by line must be present in all commits).

git commit --amend --signoff && git push --force ...

@martijneken
Restore and expand v8 patch comment
e3e0077 
Signed-off-by: Martijn Stevenson <[email protected]>
@martijneken
Copy link
Contributor Author

martijneken commented Apr 26, 2023 •
edited
Loading

Looks good, but you need to fix the DCO bot (the Signed-off-by line must be present in all commits).

Thanks, done.

We need to fix the CI with hermetic_cc_toolchain before merging anything.

ACK. #345

@martijneken
Copy link
Contributor Author

Added CI for GCC and v8. Still blocked on #345

PiotrSikora
PiotrSikora requested changes Apr 27, 2023
View reviewed changes
PiotrSikora
PiotrSikora approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora changed the title Fix v8 gcc Bazel build using -Wno-nonnull. Fixes #340. v8: fix build with GCC. Apr 28, 2023
@PiotrSikora PiotrSikora merged commit 491915a into proxy-wasm:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

@mathetake mathetake Awaiting requested review from mathetake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martijneken @PiotrSikora