Skip to content

collectors.GoCollector: Added rule support for granular metric configuration. #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2022
Merged

collectors.GoCollector: Added rule support for granular metric configuration. #1102

merged 4 commits into from
Aug 5, 2022

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Aug 3, 2022 •
edited
Loading

Fixes: #1089

cc @mknyszek

e,g to enable all runtime/metrics you can do this:

reg := prometheus.NewRegistry()
	reg.MustRegister(NewGoCollector(
		WithGoCollectorRuntimeMetrics(GoRuntimeMetricsRule{
			Matcher: regexp.MustCompile("/.*"),
		}),
	))

TODO:

  • Provide more examples on how to customize Go collector metrics
  • Allow adjusting buckets

Signed-off-by: bwplotka [email protected]

@bwplotka bwplotka requested review from kakkoyun and beorn7 August 3, 2022 12:02
bwplotka
bwplotka commented Aug 3, 2022
View reviewed changes
@bwplotka bwplotka mentioned this pull request Aug 3, 2022
Closed
@bwplotka bwplotka changed the title goCollector: Added rule support for granular metric configuration. collectors.GoCollector: Added rule support for granular metric configuration. Aug 3, 2022
@kakkoyun kakkoyun added this to the v1.13.0 milestone Aug 5, 2022
@bwplotka
Added compatibility mode with old options. (#1107)
881c608 
* Added compatibility mode with old options.

Signed-off-by: bwplotka <[email protected]>

* Copyright header.

Signed-off-by: bwplotka <[email protected]>
@mknyszek
Copy link
Contributor

mknyszek commented Aug 5, 2022

Neat! Something like this LGTM. Thanks for doing this.

bwplotka and others added 2 commits August 5, 2022 18:24
@bwplotka
Remove bucket option for now. (#1108)
c0a21ca 
Signed-off-by: bwplotka <[email protected]>
@kakkoyun
collectors/GoCollector: Add tests and examples (#1109)
434aec4 
* Add tests and examples

Signed-off-by: Kemal Akkoyun <[email protected]>

* Add docs for the presets

Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
Copy link
Member

kakkoyun commented Aug 5, 2022

@mknyszek 👋 again. I can't believe I've actually met with you in person and haven't discussed the runtime/metrics things in person. I'm terrible with the names 🙈 Sorry about that. Next time I hope 😊

@kakkoyun kakkoyun merged commit 5b7e8b2 into main Aug 5, 2022
@kakkoyun kakkoyun deleted the go-coll branch August 5, 2022 17:37
@bwplotka
Copy link
Member Author

bwplotka commented Aug 5, 2022

Yea, I would be mad on myself in your case @kakkoyun 🙈

@mknyszek
Copy link
Contributor

mknyszek commented Aug 5, 2022

Wow, I'm so sorry, I definitely failed to connect the dots too. That was you!

@vhbfernandes vhbfernandes mentioned this pull request Sep 16, 2022
Merged
2 tasks
@Jorropo Jorropo mentioned this pull request Sep 21, 2022
Open
@renovate renovate bot mentioned this pull request Oct 12, 2022
Closed
1 task
@machine424 machine424 mentioned this pull request Jun 13, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun Awaiting requested review from kakkoyun kakkoyun is a code owner

@beorn7 beorn7 Awaiting requested review from beorn7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

Add option to control Go metrics in the default collector.
3 participants
@bwplotka @mknyszek @kakkoyun