-
-
Notifications
You must be signed in to change notification settings - Fork 70
Console font bug, cursor is off #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Created by: sampottinger Hey there! The text editing area was resolved in sampottinger/processing#103 (Processing's custom text area UI was not compatible with Java 11 possibly b/c JEP 263) and should be active in your build. I wasn't able to reproduce but I'll keep digging. Which font and at what size? |
Created by: sampottinger Hey there! Sorry... I was able to reproduce the console issue with Source Code Pro 14px. This is a bit funky because I thought Processing simply used |
Created by: clankill3r I had Source Code Pro 16px on OSX. Op wo 6 nov. 2019 om 23:48 schreef A Samuel Pottinger <
|
Created by: sampottinger Hey there! So... we aren't doing custom rendering for that component... It's just a standard JTextPane (see EditorConsole). I'm slightly worried this might be https://bugs.openjdk.java.net/browse/JDK-8158370 (see also https://bugs.openjdk.java.net/browse/JDK-8156217). :-/ The resolution would be wait for Java to fix upstream or override drawing behavior. I'll be back with more soon. |
Created by: sampottinger Well... I'm not quite sure how this bug is manifesting but I traced it down to https://github.com/processing/processing4/blob/master/app/src/processing/app/ui/EditorConsole.java#L173. It appears that there's a rounding error in the text size calculation (inside Swing) but it only happens for certain gutter sizes. Using the default gutter size or switching Editor.LEFT_GUTTER to basically anything other than 44px seems to fix it. |
Created by: sampottinger @clankill3r - This will be resolved with #20. Thank you for your help! |
Created by: sampottinger Hey @clankill3r - this is previewed in a new build. See https://github.com/sampottinger/processing4 (and https://www.datadrivenempathy.com/processing). |
Created by: github-actions[bot] This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Created by: clankill3r
I reported a similar issue a while ago for the text editor but I noticed it happens in the console too.
I'm using the latest version of Samuel's website (which is from some time back, so it might been have fixed).
The text was updated successfully, but these errors were encountered: