JSSC binaries for Windows appear to be macOS files

[processing-bot]

Created by: benfry

…or at least codesign thinks so. Is it possible that the cross-compilation for these libs wasn't set quite right? They're .dylib files after all.

For that matter, we can also nix the windows_32 versions.

[processing-bot]

Created by: sampottinger

Hey there! Checking on this now. Just for housekeeping, the original issue is #71.

[processing-bot]

Created by: sampottinger

I checked both master here and the integration branch over at https://github.com/sampottinger/processing4/. The serial library is loaded and runs correctly on Windows. Apologies... I'm probably missing something obvious but I also checked and the file here does seem to be a dll (https://github.com/processing/processing4/tree/master/java/libraries/serial/library/windows64).

$ git pull
Already up to date.

$ find ./ -name *jssc*
.//java/libraries/serial/library/linux-armv6hf/libjssc.so
.//java/libraries/serial/library/linux-arm64/libjssc.so
.//java/libraries/serial/library/jssc.txt
.//java/libraries/serial/library/windows32/jssc.dll
.//java/libraries/serial/library/jssc.jar
.//java/libraries/serial/library/linux32/libjssc.so
.//java/libraries/serial/library/macosx/libjssc.jnilib
.//java/libraries/serial/library/windows64/jssc.dll
.//java/libraries/serial/library/linux64/libjssc.so

[processing-bot]

Created by: sampottinger

LMK how you want to proceed @benfry. Per your other request, removal of win32 at #120. Thanks!

[processing-bot]

Created by: benfry

It came up because notarization was complaining about these binaries inside jssc.jar:

Processing.app/Contents/Java/modes/java/libraries/serial/library/jssc.jar/natives/windows_32/libjssc.dylib
Processing.app/Contents/Java/modes/java/libraries/serial/library/jssc.jar/natives/windows_64/libjssc.dylib

It looks like there are also .dll files in the same directories, so things should function, but in the meantime I have the those .dylib entries being removed manually as part of dist as of ebe2a93.

I'll hold on #120 until you have a sense of what's going on; I just didn't want to do anything more invasive.

[processing-bot]

Created by: sampottinger

Oh! My apologies ... thank you for catching that. I will see what’s going on in there. 👀

On Aug 17, 2020, at 3:29 AM, Ben Fry notifications@github.com wrote:


It came up because notarization was complaining about these binaries inside jssc.jar:

Processing.app/Contents/Java/modes/java/libraries/serial/library/jssc.jar/natives/windows_32/libjssc.dylib
Processing.app/Contents/Java/modes/java/libraries/serial/library/jssc.jar/natives/windows_64/libjssc.dylib
It looks like there are also .dll files in the same directories, so things should function, but in the meantime I have the those .dylib entries being removed manually as part of dist as of ebe2a93.

I'll hold on #120 until you have a sense of what's going on; I just didn't want to do anything more invasive.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[processing-bot]

Created by: benfry

@sampottinger did you have a chance to look into this one? Hoping it's just something simple, but didn't want to delete things willy-nilly.

[processing-bot]

Created by: github-actions[bot]

This issue has been automatically locked. To avoid confusion with reports that have already been resolved, closed issues are automatically locked 30 days after the last comment. Please open a new issue for related bugs.