Skip to content

Rewrote Welcome in Swing #5210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

davidsun0
Copy link

@davidsun0 davidsun0 commented Aug 9, 2017

Changed the Welcome from a child of WebFrame to a child of JFrame.

This change fixes GUI problems #3911, #3912, and potentially #4896. (If it does not fix 4896, it should make it very easy to - the only changes needed are swapping out the logo image and resizing the window)
Closing the window will change the preferences for showing the welcome screen each time.
All text is now tied to the buttons and check boxes, making it more user friendly.
The Welcome screen should also resize to display well on high resolution displays, but I don't have a computer to test it on.

I also extracted the text out of the GUI. I couldn't find where the translations of the old Welcome screen are, but this will also make it easier to translate the welcome screen. Only a dozen phrases are needed, and the file format will make it easy to replace the strings in the future.

Closes #3911
Closes #3912

@VictorGaiva
Copy link

VictorGaiva commented Nov 1, 2017

It did not fix #3911. It is still pretty hard to fix this. What is the purpose of the welcome screen? Maybe an approach like the welcome screen from Visual Code might be a good idea. It would need a lot of changes but I am willing to try it.

@benfry
Copy link
Contributor

benfry commented Mar 18, 2018

Thanks for the attempt, though even after putting in some time with it (5b672a1 and ddb81c8), it's visually still too messy for us to use.

screen shot 2018-03-18 at 12 41 38 pm

This is why we did the HTML version in the first place—getting UIs to look good in Swing is just really difficult.

But I've done some other fixes and think we're in good shape for the next release. Thanks for taking a look.

@benfry benfry closed this Mar 18, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

click "show this welcome" text to check/uncheck the box un-checking "show this message" and closing the welcome window doesn't store the change
3 participants