Skip to content

update icon padding in TextInput #6302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 10, 2025

Conversation

llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Jul 7, 2025

Closes https://github.com/github/primer/issues/5326

Changelog

New

Changed

Updated padding in leading & trailing visual TextInput to 8px from 12px, unless size of input is large, in which case padding stays as 12px.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Jul 7, 2025

🦋 Changeset detected

Latest commit: 19377fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 7, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 7, 2025
Copy link
Contributor

github-actions bot commented Jul 7, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.01 KB (0%)
packages/react/dist/browser.umd.js 92.29 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6302 July 7, 2025 23:06 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6302 July 7, 2025 23:16 Inactive
@llastflowers llastflowers changed the title change padding before leading visual and after trailing visual from 1… update icon padding in TextInput Jul 7, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6302 July 7, 2025 23:35 Inactive
@llastflowers llastflowers added this pull request to the merge queue Jul 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/390055

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 10, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 10, 2025
@llastflowers llastflowers added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 4c9aa4b Jul 10, 2025
43 checks passed
@llastflowers llastflowers deleted the llastflowers/5326/TextInput-icon-padding-fix branch July 10, 2025 18:48
@primer primer bot mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants