-
Notifications
You must be signed in to change notification settings - Fork 617
Migrate Label.test.tsx from Jest to Vitest #6301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Label.test.tsx
file from Jest to Vitest as part of the design system's testing framework transition. The migration includes updating import statements, simplifying test code, and configuring both test runners appropriately.
- Updates test file to use Vitest imports and syntax
- Adds Label tests to Vitest browser configuration
- Excludes Label tests from Jest configuration to prevent duplicate execution
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/Label/Label.test.tsx | Migrates test imports to Vitest and simplifies test implementation |
packages/react/vitest.config.browser.mts | Adds Label test files to Vitest browser test inclusion pattern |
packages/react/jest.config.js | Excludes Label test directory from Jest execution |
Comments suppressed due to low confidence (1)
packages/react/src/Label/Label.test.tsx:25
- The axe accessibility test was removed during migration, which reduces test coverage for accessibility compliance. Consider adding equivalent accessibility tests using Vitest or ensure these are covered elsewhere in the test suite.
})
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo! Thanks for this 🥳
This PR migrates the
Label.test.tsx
file from Jest to Vitest.