Skip to content

Migrate Avatar and AvatarStack tests from Jest to Vitest #6293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ module.exports = {
'<rootDir>/src/ActionBar/',
'<rootDir>/src/ActionList/',
'<rootDir>/src/AnchoredOverlay/',
'<rootDir>/src/Avatar/',
'<rootDir>/src/AvatarStack/',
'<rootDir>/src/Banner/',
'<rootDir>/src/Blankslate/',
'<rootDir>/src/Box/',
Expand Down
66 changes: 21 additions & 45 deletions packages/react/src/Avatar/Avatar.test.tsx
Original file line number Diff line number Diff line change
@@ -1,67 +1,43 @@
import {describe, expect, it} from 'vitest'
import {render, screen} from '@testing-library/react'
import {Avatar} from '..'
import {ThemeProvider} from '../ThemeProvider'
import theme from '../theme'
import {px, render, behavesAsComponent, checkExports} from '../utils/testing'
import {render as HTMLRender, screen} from '@testing-library/react'
import axe from 'axe-core'

describe('Avatar', () => {
behavesAsComponent({
Component: Avatar,
options: {
skipAs: true,
},
})

checkExports('Avatar', {
default: Avatar,
})

it('should support `className` on the outermost element', () => {
const Element = () => <Avatar src="primer.png" className={'test-class-name'} />
expect(HTMLRender(<Element />).container.firstChild).toHaveClass('test-class-name')
})

it('should have no axe violations', async () => {
const {container} = HTMLRender(<Avatar src="primer.png" />)
const results = await axe.run(container)
expect(results).toHaveNoViolations()
expect(render(<Element />).container.firstChild).toHaveClass('test-class-name')
})

it('renders small by default', () => {
const size = 20
const result = render(<Avatar src="primer.png" />)
expect(result.props.width).toEqual(size)
expect(result.props.height).toEqual(size)
render(<Avatar src="primer.png" data-testid="avatar" />)
const avatar = screen.getByTestId('avatar')
expect(avatar).toHaveAttribute('width', size.toString())
expect(avatar).toHaveAttribute('height', size.toString())
})

it('respects the size prop', () => {
const result = render(<Avatar size={40} src="primer.png" alt="github" />)
expect(result.props.width).toEqual(40)
expect(result.props.height).toEqual(40)
render(<Avatar size={40} src="primer.png" alt="github" data-testid="avatar" />)
const avatar = screen.getByTestId('avatar')
expect(avatar).toHaveAttribute('width', '40')
expect(avatar).toHaveAttribute('height', '40')
})

it('passes through the src prop', () => {
expect(render(<Avatar src="primer.png" alt="" />).props.src).toEqual('primer.png')
render(<Avatar src="primer.png" alt="" data-testid="avatar" />)
const avatar = screen.getByTestId('avatar')
expect(avatar).toHaveAttribute('src', 'primer.png')
})

it('respects margin props', () => {
expect(render(<Avatar src="primer.png" alt="" sx={{m: 2}} />)).toHaveStyleRule('margin', px(theme.space[2]))
})

it('should support the `style` prop without overriding internal styles', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this test was removed but it should not be removed during this refactor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right! I've restored the missing test "should support the style prop without overriding internal styles". The test has been adapted to work properly in the Vitest browser environment by checking the style attribute directly. All Avatar tests are now passing (6/6). Fixed in 4c80e18.

HTMLRender(
<Avatar
data-testid="avatar"
src="primer.png"
style={{
background: 'black',
}}
/>,
render(
<ThemeProvider theme={theme}>
<Avatar src="primer.png" alt="" sx={{m: 2}} data-testid="avatar" />
</ThemeProvider>,
)

expect(screen.getByTestId('avatar')).toHaveStyle({
background: 'black',
['--avatarSize-regular']: '20px',
})
const avatar = screen.getByTestId('avatar')
expect(avatar).toHaveStyle(`margin: 8px`)
})
})
38 changes: 11 additions & 27 deletions packages/react/src/AvatarStack/AvatarStack.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {describe, expect, it} from 'vitest'
import {render} from '@testing-library/react'
import {AvatarStack} from '..'
import {render, behavesAsComponent, checkExports} from '../utils/testing'
import {render as HTMLRender} from '@testing-library/react'
import axe from 'axe-core'

const avatarComp = (
<AvatarStack>
Expand All @@ -21,17 +20,7 @@
</AvatarStack>
)

describe('Avatar', () => {
behavesAsComponent({
Component: AvatarStack,
toRender: () => avatarComp,
options: {skipAs: true},
})

checkExports('AvatarStack', {
default: AvatarStack,
})

describe('AvatarStack', () => {
it('should support `className` on the outermost element', () => {
const Element = () => (
<AvatarStack className={'test-class-name'}>
Expand All @@ -41,26 +30,21 @@
<img src="https://avatars.githubusercontent.com/github" alt="" />
</AvatarStack>
)
expect(HTMLRender(<Element />).container.firstChild).toHaveClass('test-class-name')
})

it('should have no axe violations', async () => {
const {container} = HTMLRender(avatarComp)
const results = await axe.run(container)
expect(results).toHaveNoViolations()
expect(render(<Element />).container.firstChild).toHaveClass('test-class-name')
})

it('respects alignRight props', () => {
expect(render(rightAvatarComp)).toMatchSnapshot()
const {container} = render(rightAvatarComp)
expect(container.firstChild).toMatchSnapshot()

Check failure on line 38 in packages/react/src/AvatarStack/AvatarStack.test.tsx

View workflow job for this annotation

GitHub Actions / copilot

src/AvatarStack/AvatarStack.test.tsx > AvatarStack > respects alignRight props

Error: Snapshot `AvatarStack > respects alignRight props 1` mismatched - Expected + Received <span - class="pc-AvatarStack--three-plus pc-AvatarStack--right prc-AvatarStack-AvatarStack-LcJ4R" + class="pc-AvatarStack--three-plus pc-AvatarStack--right prc-AvatarStack-AvatarStack-N-r3C" data-align-right="" data-avatar-count="3+" data-responsive="" style="--stackSize-narrow: 20px; --stackSize-regular: 20px; --stackSize-wide: 20px;" > <div - class="pc-AvatarStackBody prc-AvatarStack-AvatarStackBody-LVwsN" + class="pc-AvatarStackBody prc-AvatarStack-AvatarStackBody-mSyoJ" tabindex="0" > <img alt="" - class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL" + class="pc-AvatarItem prc-AvatarStack-AvatarItem-nS1mt" src="https://avatars.githubusercontent.com/primer" /> <img alt="" - class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL" + class="pc-AvatarItem prc-AvatarStack-AvatarItem-nS1mt" src="https://avatars.githubusercontent.com/github" /> <img alt="" - class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL" + class="pc-AvatarItem prc-AvatarStack-AvatarItem-nS1mt" src="https://avatars.githubusercontent.com/primer" /> <img alt="" - class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL" + class="pc-AvatarItem prc-AvatarStack-AvatarItem-nS1mt" src="https://avatars.githubusercontent.com/github" /> </div> </span> ❯ src/AvatarStack/AvatarStack.test.tsx:38:33
})

it('should have a tabindex of 0 if there are no interactive children', () => {
const {container} = HTMLRender(avatarComp)
const {container} = render(avatarComp)
expect(container.querySelector('[tabindex="0"]')).toBeInTheDocument()
})

it('should not have a tabindex if there are interactive children', () => {
const {container} = HTMLRender(
const {container} = render(
<AvatarStack>
<button type="button">Click me</button>
</AvatarStack>,
Expand All @@ -69,7 +53,7 @@
})

it('should not have a tabindex if disableExpand is true', () => {
const {container} = HTMLRender(
const {container} = render(
<AvatarStack disableExpand>
<img src="https://avatars.githubusercontent.com/primer" alt="" />
<img src="https://avatars.githubusercontent.com/github" alt="" />
Expand All @@ -80,12 +64,12 @@

it('should support `style` prop on the outermost element', () => {
const style = {backgroundColor: 'red'}
const {container} = HTMLRender(
const {container} = render(
<AvatarStack style={style}>
<img src="https://avatars.githubusercontent.com/primer" alt="" />
<img src="https://avatars.githubusercontent.com/github" alt="" />
</AvatarStack>,
)
expect(container.firstChild).toHaveStyle('background-color: red')
expect(container.firstChild).toHaveStyle('background-color: rgb(255, 0, 0)')
})
})
Original file line number Diff line number Diff line change
@@ -1,42 +1,36 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`Avatar respects alignRight props 1`] = `
exports[`AvatarStack > respects alignRight props 1`] = `
<span
className="pc-AvatarStack--three-plus pc-AvatarStack--right AvatarStack"
class="pc-AvatarStack--three-plus pc-AvatarStack--right prc-AvatarStack-AvatarStack-LcJ4R"
data-align-right=""
data-avatar-count="3+"
data-responsive=""
style={
{
"--stackSize-narrow": "20px",
"--stackSize-regular": "20px",
"--stackSize-wide": "20px",
}
}
style="--stackSize-narrow: 20px; --stackSize-regular: 20px; --stackSize-wide: 20px;"
>
<div
className="pc-AvatarStackBody AvatarStackBody"
tabIndex={0}
class="pc-AvatarStackBody prc-AvatarStack-AvatarStackBody-LVwsN"
tabindex="0"
>

<img
alt=""
className="pc-AvatarItem AvatarItem"
class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL"
src="https://avatars.githubusercontent.com/primer"
/>
<img
alt=""
className="pc-AvatarItem AvatarItem"
class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL"
src="https://avatars.githubusercontent.com/github"
/>
<img
alt=""
className="pc-AvatarItem AvatarItem"
class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL"
src="https://avatars.githubusercontent.com/primer"
/>
<img
alt=""
className="pc-AvatarItem AvatarItem"
class="pc-AvatarItem prc-AvatarStack-AvatarItem-ZlFbL"
src="https://avatars.githubusercontent.com/github"
/>
</div>
Expand Down
2 changes: 2 additions & 0 deletions packages/react/vitest.config.browser.mts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ export default defineConfig({
'src/ActionBar/**/*.test.?(c|m)[jt]s?(x)',
'src/ActionList/**/*.test.?(c|m)[jt]s?(x)',
'src/AnchoredOverlay/**/*.test.?(c|m)[jt]s?(x)',
'src/Avatar/**/*.test.?(c|m)[jt]s?(x)',
'src/AvatarStack/**/*.test.?(c|m)[jt]s?(x)',
'src/Banner/**/*.test.?(c|m)[jt]s?(x)',
'src/Blankslate/**/*.test.?(c|m)[jt]s?(x)',
'src/Box/**/*.test.?(c|m)[jt]s?(x)',
Expand Down