-
Notifications
You must be signed in to change notification settings - Fork 616
remove unused contrast
from Select component
#6272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ef24d65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the unused contrast
prop from the Select
component to tidy up its API.
- Eliminates
contrast
from the prop destructuring and forwarding inSelect.tsx
. - Adds a changeset to note the removal in a patch release.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/react/src/Select/Select.tsx | Remove contrast prop usage in Select component |
.changeset/dirty-chairs-invent.md | Add changeset entry for removing contrast |
Comments suppressed due to low confidence (2)
packages/react/src/Select/Select.tsx:40
- The
contrast
prop is still declared in theSelectProps
interface (elsewhere) but has been removed from use—ensure it's also removed from the type definition and any public API docs to avoid exposing an unused prop.
className,
packages/react/src/Select/Select.tsx:54
- Since
contrast
is no longer forwarded toTextInputWrapper
, remove its mention from component documentation, PropTables (e.g., Storybook), and any related tests to keep docs in sync with the API.
block={block}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a comment around how to sequence breaking changes, let me know what you think!
With this change, would we also want to Omit
contrast from the StyledWrapperProps
, as well, so it doesn't show up in the type info? (I think that's where it comes from but don't quote me on that lol)
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/388667 |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
🟢 golden-jobs completed with status |
Closes https://github.com/github/primer/issues/5307
Changelog
New
Changed
Removed
Instances of
contrast
inSelect
component, as it is unused.Rollout strategy
Testing & Reviewing
Merge checklist