-
Notifications
You must be signed in to change notification settings - Fork 615
chore(CheckboxOrRadioGroup): Remove the CSS modules feature flag from the CheckboxOrRadioGroup component #6013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2140190 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/376643 |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the now-obsolete CSS modules feature flag and all associated conditional rendering from the CheckboxOrRadioGroup component and its subcomponents, simplifying them to always use CSS modules and the new BoxWithFallback wrapper.
- Remove the
CSS_MODULES_FLAG
feature flag and related imports - Simplify
CheckboxOrRadioGroupLabel
andCheckboxOrRadioGroupCaption
to a single implementation path - Replace the toggled styled component in
CheckboxOrRadioGroup
withBoxWithFallback
and drop conditional branches
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/react/src/internal/components/CheckboxOrRadioGroup/FeatureFlag.tsx | Deleted feature flag constant |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupLabel.tsx | Removed feature-flag branches and imports |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupCaption.tsx | Removed feature-flag branches and imports |
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx | Replaced toggleStyledComponent logic with BoxWithFallback; removed conditional branches |
.changeset/afraid-pens-return.md | Added changeset recording removal of the feature flag |
Comments suppressed due to low confidence (2)
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx:117
- Remove the
as: 'div'
property from the props spread on this<div>
wrapper, since it renders a native<div>
and theas
attribute is invalid HTML.
as: 'div',
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupLabel.tsx:23
- The
sx
prop is being destructured but never passed through toVisuallyHidden
. Either forwardsx={sx}
or remove it from the component signature.
sx,
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx
Show resolved
Hide resolved
… the CheckboxOrRadioGroup component (#6013)
Closes https://github.com/github/primer/issues/4305
Changelog
New
Changed
Removed
Remove the CSS modules feature flag from the CheckboxOrRadioGroup component
Rollout strategy
Testing & Reviewing
Merge checklist