Changes required for SDK 35 (Android 15) target #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Pull Requests - Tested all three stacked pull requests to success I think... newer Android Studio has some continual bugs with merging and branches that its making it very difficult to test that. But, only seen as Android Studio problem and git merge expected to be good if merged correctly.
Fully fixes
Some notes
Fixes Action bar back button missing from fragment screens.
Fully tested on Android 6, 8, 14, and 15 (rotation, browse away and back with text edit setting open, back buttons, movement, themes, etc). Briefly tested on Android 13 also with no problems seen.
Theme "mixed" changed to daynight. Note found in styles.xml partially wants this anyway. So, there's dark, light, and daynight. Its probably about how it should be.
User Edit > EditTexts 'android:fitsSystemWindows="false"' is used to fix the EditText's either having some sort of overlay or are pushed off the screen, to where nothing can be seen.
SDK 35 complains now about FsTileService min target being 24 while app min is 23. Testing on Android 6 shows this can still be ignored. Left unsuppressed, uncommented. Builds and works fine with its complaint here.
Other options do exist, like fully removing the action bar, but this pull request offers same looking UI.
Not tested on folding screen, tablets, etc.