REL_2_5-PBCKP-236 #531
Merged
REL_2_5-PBCKP-236 #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 11, 2022 04:14
…t_remote_major_pg fixes
avaness
commented
Sep 16, 2022
avaness
commented
Sep 16, 2022
avaness
commented
Sep 16, 2022
funny-falcon
approved these changes
Sep 27, 2022
src/utils/remote.c
Outdated
| static bool check_certified() | ||
| { | ||
| return strstr(PGPRO_VERSION_STR, "(certified)") || | ||
| strstr(PGPRO_VERSION_STR, ("(standard certified)")); |
There was a problem hiding this comment.
А зачем тут скобочки вокруг строки?
There was a problem hiding this comment.
PGPRO_VERSION_STR выглядит как "PostgresPro 11.17.1 (certified) on x86_64-pc-linux-gnu, ...", скобочки отсюда, чтобы быть более strict.
src/utils/remote.c
Outdated
|
|
||
| for (int i = 0; i < compatibility_params_array_size; i+=2) | ||
| for (int i = 0; i < sizeof compatibility_params; i+=2) |
There was a problem hiding this comment.
Было правильно, зря убрал.
src/utils/remote.c
Outdated
| { | ||
| if (compatibility_params[i].strval != NULL) | ||
| result_size += snprintf(compatibility_buf + result_size, compatibility_buf_size - result_size, | ||
| "%s=%s/n", |
There was a problem hiding this comment.
Слэш в другую сторону. И ниже тоже.
| "CREATE TABLE ultimate_question2 AS SELECT 42 AS answer") | ||
|
|
||
| # do delta catchup with remote pg_probackup agent with another postgres major version | ||
| # this DELTA backup should fail without PBCKP-236 patch. |
There was a problem hiding this comment.
А тест не должен падать в любом случае? По крайней мере, кажется что с патчем-то он точно должен падать.
There was a problem hiding this comment.
должен, он вообще не должен срабатывать, так как ссылается на абсолютный путь на бинарь другой версии. мне не понятно почему CI не репортит это. на планерке спрошу гипотезы.
avaness
force-pushed
the
REL_2_5-PBCKP-236
branch
from
18f0b06 to
9b3dc02
Compare
avaness
force-pushed
the
REL_2_5-PBCKP-236
branch
from
9b3dc02 to
26f9992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@funny-falcon please review