Self outputting renderers #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to avoid a circular dependency in a commit I'm working on. Also just good practice to try to import from the most specific module possible.
Note that this breaks @output_transformer decorator usage that doesn't include (). I tried to make it work but couldn't figure out the type annotations.
wch
reviewed
Oct 4, 2023
wch
reviewed
Oct 4, 2023
wch
reviewed
Oct 4, 2023
wch
reviewed
Oct 4, 2023
Collaborator
wch
left a comment
wch
left a comment
There was a problem hiding this comment.
PR looks good overall -- I just have a few small questions and comments.
@render.xxx decorators now self-register with the currently active session's (or module's) output. You can still use an explicit output decorator if you want to set other options, although at this time doing so doesn't prevent the initial implicit output registration from happening.
wch
reviewed
Oct 11, 2023
wch
reviewed
Oct 11, 2023
wch
approved these changes
Oct 11, 2023
Co-authored-by: Winston Chang <[email protected]>
schloerke
added a commit
that referenced
this pull request
Oct 13, 2023
* main: Remove leading newline Stop testing on Python 3.12 Update changelog Check that file is autogenerated before overwriting Run tests on Python 3.12 Add support for Quarto integration (#746) Revert inadvertent whitespace change Update shinylive version for docs (#759) Self outputting renderers (#747)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@output_transformersso that@output_transformersworks again; currently@output_transformers()must be used.