check-migrations: Cache & Download snapshot only once per day #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we always redownloaded the snapshot every time running the job. Now the snapshots are generated 1am every day and then used from there.
bkontur
reviewed
Jul 23, 2025
| cargo install -q --git https://github.com/paritytech/try-runtime-cli --tag v0.8.0 --locked && try-runtime --version | ||
|
|
||
| cargo build --profile production -p ${{ matrix.runtime.package }} --features try-runtime -q --locked | ||
| try-runtime --version |
There was a problem hiding this comment.
Isn't try-runtime installed only for generate-snapshots?
Don't we need to pass it also via "Download Snapshot" or something?
bkontur
reviewed
Jul 23, 2025
bkontur
approved these changes
Jul 23, 2025
ggwpez
reviewed
Jul 23, 2025
ggwpez
reviewed
Jul 23, 2025
| - name: Generate snapshot for ${{ matrix.runtime.name }} | ||
| run: | | ||
| echo "Generating snapshot for ${{ matrix.runtime.name }}..." | ||
| cargo install -q --git https://github.com/paritytech/try-runtime-cli --tag v0.8.0 --locked |
There was a problem hiding this comment.
There is a binary, I assume building it is a bit slow: https://github.com/paritytech/polkadot-sdk/blob/1756db06b1d7794a23b7d069d76716a64d0524cc/.github/workflows/check-runtime-migration.yml#L86-L89
Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we always redownloaded the snapshot every time running the job. Now the snapshots are generated 1am every day and then used from there.