Ambassador Configurations #736

Doordashcon · 2025-05-21T16:42:53Z

Ambassador Configurations

This PR implements the revised technical specification for the Ambassador Program. Key changes include:

Core Functionality

Rank System
- Added 7 ranks (0-6) with distinct voting powers:
  - Advocate (0): n/a
  - Associate (1): 1 vote
  - Lead (2): 3 votes
  - Senior (3): 6 votes
  - Principal (4): 10 votes
  - Global (5): 15 votes
  - Global (6): 21 votes
Membership Management
- Off-chain Identity verification
- Offboarding:
  - Stepped Decay in achieved through bump which can be automated off-chain or through Task API.
  - Removal if necessary is achieved through OpenGov voting for all members / SeniorAmbassador for only AssociateAmbassador.
- Promotion & Demotion:
  - Any ranked(i.e. I - VI) member can request promotion by submitting a referanda.
  - Demotion is achieved through OpenGov voting for all members / SeniorAmbassador for only AssociateAmbassador.
Voting System
- Rank-weighted voting for internal decisions.
- Monthly voting schedule (last working day).

Treasury & Tipping

TREASURY origin and track.
Tip origin and track.

Implementations

Removed Ambassador Salary pallet
pallet-ranked-collective migration + unit testing

ltfschoen · 2025-08-01T07:28:15Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

 ///
 /// The value of 21 comes from the initial OpenGov proposal: <https://github.com/polkadot-fellows/runtimes/issues/264>
 pub struct AmbassadorMemberCount;
 impl MaybeConvert<Rank, MemberIndex> for AmbassadorMemberCount {
 	fn maybe_convert(rank: Rank) -> Option<MemberIndex> {
-		(rank == 3).then_some(21)
+		(rank == 6).then_some(21)


There isn't such a limit in the latest manifesto

system-parachains/collectives/collectives-polkadot/src/ambassador/migration.rs

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

ggwpez · 2025-08-21T13:38:46Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

@@ -131,29 +124,16 @@ impl pallet_ranked_collective::Config<AmbassadorCollectiveInstance> for Runtime
 	#[cfg(feature = "runtime-benchmarks")]


Do you want to enable some promotion logic or wait for it until we have a smart contract?

ggwpez · 2025-08-21T13:40:40Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

-	#[cfg(feature = "runtime-benchmarks")]
+	type MinRankOfClass = tracks::MinRankOfClass;
+	type VoteWeight = Geometric;
+	type AddOrigin = OpenGovOrGlobalHead;


Additional Ambassadors will not be able to join until Polkadot Hub is ready and Jesse can build a smart contract to allow the joining process

Should we maybe leave this blank?

AddOrigin & ExchangeOrigin can be?

pub type RootOrOpenGov = EitherOfDiverse< EnsureRoot<AccountId>, EnsureXcm<IsVoiceOfBody<GovernanceLocation, FellowshipAdminBodyId>>, >;

Yes reasonable.

ggwpez · 2025-08-21T13:42:40Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

+	type VoteWeight = Geometric;
+	type AddOrigin = OpenGovOrGlobalHead;
+	type ExchangeOrigin = OpenGovOrGlobalHead;
+	type MemberSwappedHandler = crate::AmbassadorCore;
 	type MaxMemberCount = ();


We should limit this somehow since its running on a system chain. 512 or 1024 maybe? It can be increased in the future but with the current config it would allow one malicious HA to add millions of accounts and slow down the collectives chain.

I did not consider this...

Considering the event of a malicious HA, adding members through OpenGov seems like a more general solution?

The limits can still be abused IMO.

Additional Ambassadors will not be able to join until Polkadot Hub is ready and Jesse can build a smart contract to allow the joining process.

Maybe we just disable it for now? (from the gdoc manifesto)

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

ggwpez · 2025-08-22T11:57:40Z

system-parachains/collectives/collectives-polkadot/src/ambassador/migration.rs

+		// This list was created by collating community-submitted addresses from an off-chain document source
+		// https://docs.google.com/spreadsheets/d/1uE5nDKuMZDqlj9q2tvnk_tngyU1Cokl0tQKwSigvJLA/edit?gid=0#gid=0,
+		// then converting each Polkadot SS58 address to its raw public key (32-byte hex) using:
+		// `subkey inspect <SS58_ADDRESS>`


Please add something like this, i put it into the preimages pallet onchain now.

A batched call with two remarks has been persisted onto the Collectives Parachchain preimages. Hash: `0xb6087d77d3b4b5966b9096b459283ea6f5617f4a96d1b4829191439f96fe3c6b` Transaction link: https://collectives-polkadot.subscan.io/extrinsic/7035411-2

ggwpez · 2025-08-22T12:00:07Z

system-parachains/collectives/collectives-polkadot/src/ambassador/migration.rs

+				for _ in 0..desired_rank {
+					let _ = <RankedCollective<T, I> as RankedMembers>::promote(&who);
+					// 1 write to `IdToIndex` and `IndexToId` per promotion
+					weight.saturating_accrue(T::DbWeight::get().writes(2));


Could also use the weights of the extrinsics but i dont mind.

Weights updated

system-parachains/collectives/collectives-polkadot/src/ambassador/migration.rs

ggwpez · 2025-08-22T12:09:22Z

system-parachains/collectives/collectives-polkadot/src/ambassador/origins.rs

+	}
+
+	/*
+	/// A `TryMorph` implementation which is designed to convert an aggregate `RuntimeOrigin`


If we dont need it then you can delete it.

ggwpez · 2025-08-22T12:55:17Z

system-parachains/collectives/collectives-polkadot/src/ambassador/tracks.rs

+			retention @ 11..=15 => retention - 8,
+			// A promotion vote; the track ID turns out to be 18 more than the minimum required
+			// rank.
+			promotion @ 21..=25 => promotion - 18,


I think promotion and retention requires votes from the members one rank above - not two (like in the tech fellowship).

These configurations match the Tech Fellowship

Correct, one rank above upwards as we only have 6 ranks.

ggwpez · 2025-08-22T12:56:41Z

system-parachains/collectives/collectives-polkadot/src/ambassador/tracks.rs

+			promotion @ 21..=25 => promotion - 18,
+			// A fast promotion vote; the track ID turns out to be 28 more than the minimum required
+			// rank.
+			fast_promote @ 31..=33 => fast_promote - 28,


Did you fix this? Please close the fixed ones.

system-parachains/collectives/collectives-polkadot/src/ambassador/tracks.rs

ggwpez

Looks generally good. I put some comments.

One more Q: Should we set the core-fellowship parameters in a migration as well?
Stuff like demotion_period (per rank)? Maybe the default zero values are sane - dont know. But it would need to be done otherwise by the ParamsOrigin.

system-parachains/collectives/collectives-polkadot/src/ambassador/migration.rs

bkchr · 2025-09-10T07:06:40Z

This should go on chain as a completely separate release, so the community can vote on this properly.

lucycldn · 2025-09-10T19:17:16Z

This should go on chain as a completely separate release, so the community can vote on this properly.

Appreciate the point. Given the documented path to date, our reading of OpenGov is that a further on-chain vote isn’t required. I’ll share the timeline and reasoning in the Open Element channel for discussion.

bkchr · 2025-09-10T20:15:17Z

Given the documented path to date, our reading of OpenGov is that a further on-chain vote isn’t required.

What documented path?

lucycldn · 2025-09-11T21:49:52Z

Given the documented path to date, our reading of OpenGov is that a further on-chain vote isn’t required.

What documented path?

There has been a miscommunication / understanding on process here and I am clarifying the Ambassador sentiment before responding on behalf. Ultimately, the Tech Fellowship is the final gatekeeper here, so if we need to have a separate release then are supportive.

Doordashcon · 2025-09-12T10:53:36Z

system-parachains/collectives/collectives-polkadot/src/ambassador/mod.rs

+/// - ...with an excess rank of 6 gets 21 votes.
+pub struct Geometric;
+impl Convert<Rank, Votes> for Geometric {
+	fn convert(r: Rank) -> Votes {


This is causing the failing vote benchmark

bkchr · 2025-09-12T12:48:06Z

the Tech Fellowship is the final gatekeeper here

I don't want to be a gatekeeper, but I also don't want to include things that are not wanted. As said, we can do a release that only contains these changes and then we let the voters decide.

github-actions · 2025-09-12T12:58:15Z

Review required! Latest push from author must always be reviewed

Doordashcon added 6 commits May 21, 2025 17:40

configure ranked-collective-pallet

42ba9a9

Deprecate AddOrigin

2409b9c

test case config

548afe1

add pallet-core-fellowship-ambassador & pallet-salary-ambassador

139fd1c

salary removal

a275087

add tracks

f243138

Doordashcon marked this pull request as ready for review May 27, 2025 15:04

Doordashcon added 10 commits May 30, 2025 10:00

configure core fellowship for benchmark generation

1636c5d

add weights

5973e1c

fmt

47a62e8

clippy fixed?

f40a94f

nit

40d5eef

Use VoteWeight in pallet

4416cc0

merging conflicts...

499a62f

Merge origin/main into ACONFIG

7a1b935

remove salary

164220a

cargo fmt

4bb9a7a

ltfschoen reviewed Aug 1, 2025

View reviewed changes

Doordashcon added 12 commits August 14, 2025 15:26

remove member limit

4c33758

use existing pallet, Params

fafb0f8

Merge branch 'main' into ACONFIG

658837c

Merge branch 'main' into ACONFIG

d33d974

nit

396470f

clippy fix

f3c50d8

all accounts

b3ff193

Merge branch 'main' into ACONFIG

8ce0bff

fix clippy

c2aa633

add ambassadorcore migration

e2d4783

nit

07d0d75

nit

1da4484

nit

0165105

ggwpez reviewed Aug 21, 2025

View reviewed changes

Doordashcon added 3 commits August 21, 2025 21:02

nit

b3c1706

nit

ea79f28

clippy fix

1e28383

ggwpez reviewed Aug 22, 2025

View reviewed changes

system-parachains/collectives/collectives-polkadot/src/ambassador/migration.rs Show resolved Hide resolved

ggwpez reviewed Aug 22, 2025

View reviewed changes

system-parachains/collectives/collectives-polkadot/src/ambassador/tracks.rs Show resolved Hide resolved

ggwpez reviewed Aug 22, 2025

View reviewed changes

Doordashcon added 2 commits August 26, 2025 13:20

add CoreParams Migration

d2b0dfe

clippy fix

2b4d2ef

pandres95 approved these changes Sep 9, 2025

View reviewed changes

ggwpez reviewed Sep 9, 2025

View reviewed changes

system-parachains/collectives/collectives-polkadot/src/ambassador/migration.rs Outdated Show resolved Hide resolved

ggwpez approved these changes Sep 9, 2025

View reviewed changes

Merge branch 'main' into ACONFIG

89bd93b

Doordashcon commented Sep 12, 2025

View reviewed changes

nit, remove global retention vote, add extrinsic weight for migration

3c79d5d

Doordashcon mentioned this pull request Sep 12, 2025

Include rank_to_votes Converter for Vote benchmark in pallet-rank-collective. paritytech/polkadot-sdk#9730

Open

2 tasks

github-actions bot requested review from ggwpez and pandres95 September 12, 2025 12:58

		@@ -131,29 +124,16 @@ impl pallet_ranked_collective::Config<AmbassadorCollectiveInstance> for Runtime
		#[cfg(feature = "runtime-benchmarks")]

Ambassador Configurations #736

Are you sure you want to change the base?

Ambassador Configurations #736

Uh oh!

Conversation

Doordashcon commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ambassador Configurations

Core Functionality

Treasury & Tipping

Implementations

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggwpez Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggwpez Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bkchr commented Sep 10, 2025

Uh oh!

lucycldn commented Sep 10, 2025

Uh oh!

bkchr commented Sep 10, 2025

Uh oh!

lucycldn commented Sep 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkchr commented Sep 12, 2025

Uh oh!

github-actions bot commented Sep 12, 2025

Uh oh!

Uh oh!

Doordashcon commented May 21, 2025 •

edited

Loading

ggwpez Aug 22, 2025 •

edited

Loading

ggwpez Aug 22, 2025 •

edited

Loading