Skip to content

upgrade plotly.js #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

upgrade plotly.js #1450

wants to merge 14 commits into from

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jan 9, 2019

TODO

These plotly.js release notes will require some R changes:

  • title attributes linked to strings are now deprecated. Please use title.text instead to fill in your title text [#3276]
  • title* attributes are now deprecated. They moved to title.*. For example, colorbar.titleside is now colorbar.title.side [#3276]

FWIW, I'm pretty sure layout.title, layout.titlefont, layout[axisid].title, layout[axisid].titlefont, marker.colorbar.title, marker.colorbar.titlefont, marker.colorbar.titleside, and carpet-specific attributes are the only ones effected.

  • It looks like these attributes still work, but be good form to identify these cases on the R side and throw an information deprecation message/warning.
  • Update any 'internal' logic using these attributes to use the new nested structure.
  • Would also be a good time to have ggplotly() leverage the new layout.title and layout[axisid].title placement attributes

@cpsievert cpsievert changed the title upgrade to plotly.js v1.43 upgrade plotly.js Feb 11, 2019
@cpsievert
Copy link
Collaborator Author

Closing in favor of #1506

@cpsievert cpsievert closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant