allow_duplicates to work with Loading #3289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSd3v
requested review from
T4rk1n,
ndrezn,
gvwilson and
emilykl
as code owners
T4rk1n
reviewed
Apr 24, 2025
| @@ -45,9 +45,9 @@ const loadingSelector = (componentPath, targetComponents) => state => { | |||
| return false; | |||
| } | |||
| if (Array.isArray(target)) { | |||
| return includes(l.property, target); | |||
| return includes(l.property.split('@')[0], target); | |||
There was a problem hiding this comment.
Think it might be better to set that in the reducer or the action.
There is a // duplicate outputs comment that I think may have been a todo here:
To change on the callback would be here:
There was a problem hiding this comment.
I was curious about that, didnt want to mess around with the hash in the callback. Wasnt sure about side-effects of that change.
There was a problem hiding this comment.
Makes the debug=True in the loading much nicer, since it strips the hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3288