Fix typing component generation & explicitize_args #3287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
commented
Apr 22, 2025
Comment on lines
-28
to
-30
| try: | ||
| from dash.development.base_component import ComponentType # noqa: F401 | ||
| except ImportError: |
There was a problem hiding this comment.
Note: types defined in try except don't always resolve.
There was a problem hiding this comment.
that makes sense now that you've said it but damn - I'm liking Python's type system less and less as time goes by…
gvwilson
approved these changes
Apr 22, 2025
Comment on lines
-28
to
-30
| try: | ||
| from dash.development.base_component import ComponentType # noqa: F401 | ||
| except ImportError: |
There was a problem hiding this comment.
that makes sense now that you've said it but damn - I'm liking Python's type system less and less as time goes by…
| ComponentType = typing.TypeVar("ComponentType", bound=Component) | ||
| from dash.development.base_component import Component, _explicitize_args | ||
| {custom_imports} | ||
| ComponentType = typing.Union[ |
There was a problem hiding this comment.
I suspect this will eventually grow to Any :-)
| "func": generate_any, | ||
| "element": generate_type("ComponentType"), | ||
| "element": generate_type("Component"), |
requirements/ci.txt
Outdated
| @@ -19,3 +19,4 @@ xlrd>=2.0.1 | |||
| pytest-rerunfailures | |||
| jupyterlab<4.0.0 | |||
| pyright==1.1.398;python_version>="3.7" | |||
| mypy==1.15.0 | |||
|
|
||
| cmd = shlex.split( | ||
| f"pyright {codefile}", | ||
| f"{sys.executable} -m {module} {codefile}{extra}", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy&pyright