Skip to content

Fix incorrect cancellation of pattern matched long callbacks #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

Fix incorrect cancellation of pattern matched long callbacks #3282

merged 5 commits into from
Apr 24, 2025

Conversation

apmorton
Copy link
Contributor

@apmorton apmorton commented Apr 16, 2025 •
edited
Loading

Fixes: #3119

@apmorton apmorton marked this pull request as ready for review April 16, 2025 20:43
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken community community contribution labels Apr 21, 2025
@gvwilson
Copy link
Contributor

@T4rk1n please have a look

@T4rk1n
Copy link
Contributor

T4rk1n commented Apr 22, 2025

Need to run npm run format

T4rk1n
T4rk1n approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@T4rk1n T4rk1n merged commit e1cc4fe into plotly:dev Apr 24, 2025
3 checks passed
@apmorton apmorton deleted the am/fix-long-callback-cancellation branch April 24, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees

@T4rk1n T4rk1n

Labels
community community contribution fix fixes something broken P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pattern-matched long callbacks cancelled incorrectly
3 participants
@apmorton @gvwilson @T4rk1n