Skip to content

feat: expose the closeMenuOnSelect option in dropdown component #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2025

Conversation

12rambau
Copy link
Contributor

@12rambau 12rambau commented Mar 9, 2025

This feature have been requested multiple time by memebers of my team at work. I checked a bit on the web and multiple Threads on your forum mentioned it without providing any solution:

That's my first contribution to dash so i'm still a bit lost with everything in the repository but I simply tried to expose what is available in the react-select options. I only made changes to the JS exposed options but I'm unsure if I should modify anything from the python side.

I'll move forward with the contributor check list once I'm sure I didn't do anything stupid.

Thanks for your help.

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@gvwilson gvwilson added feature something new P1 needed for current cycle community community contribution labels Mar 10, 2025
@gvwilson
Copy link
Contributor

@T4rk1n is this small enough that we can include it in Dash 3.0, or should we aim for Dash 3.1?

@T4rk1n
Copy link
Contributor

T4rk1n commented Mar 10, 2025

should we aim for Dash 3.1?

For 3.1

@gvwilson gvwilson added P2 considered for next cycle and removed P1 needed for current cycle labels Mar 10, 2025
@12rambau
Copy link
Contributor Author

the remaining error is linked to a file that is completely out of scope with this PR and I get the same locally:

dash/_jupyter.py:459:24: E1123: Unexpected keyword argument 'color_scheme' in constructor call (unexpected-keyword-arg)

should I ignoer it or add the apropriate ignore mention ?

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good

The CI error was unrelated.

@gvwilson
Copy link
Contributor

thanks @T4rk1n - I'm OK merging with the failed percy tests if you are

@T4rk1n T4rk1n changed the base branch from dev to release/dash-3.1.0 March 20, 2025 14:30
@T4rk1n
Copy link
Contributor

T4rk1n commented Mar 20, 2025

thanks @T4rk1n - I'm OK merging with the failed percy tests if you are

The percy tests are flaky, they will require some work to make them more stable.

I'll merge new features to branch release/dash-3.1, fixes going to dev for patch releases.

@T4rk1n T4rk1n merged commit 3ca8b4d into plotly:release/dash-3.1.0 Mar 20, 2025
3 checks passed
@12rambau
Copy link
Contributor Author

You were too fast, I didn't do the changes recommended in the PR instructions (docs and changelog) should I do them in a follow-up ?

@T4rk1n
Copy link
Contributor

T4rk1n commented Mar 21, 2025

You were too fast, I didn't do the changes recommended in the PR instructions (docs and changelog) should I do them in a follow-up ?

I'll handle the changelogs and the docs repo is not public so @LiamConnors will have to take care of it.

@12rambau 12rambau deleted the close-on-select branch March 23, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants