-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: expose the closeMenuOnSelect option in dropdown component #3202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
components/dash-core-components/src/fragments/Dropdown.react.js
Outdated
Show resolved
Hide resolved
@T4rk1n is this small enough that we can include it in Dash 3.0, or should we aim for Dash 3.1? |
For 3.1 |
components/dash-core-components/src/fragments/Dropdown.react.js
Outdated
Show resolved
Hide resolved
components/dash-core-components/src/fragments/Dropdown.react.js
Outdated
Show resolved
Hide resolved
the remaining error is linked to a file that is completely out of scope with this PR and I get the same locally:
should I ignoer it or add the apropriate ignore mention ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Looks good
The CI error was unrelated.
thanks @T4rk1n - I'm OK merging with the failed percy tests if you are |
The percy tests are flaky, they will require some work to make them more stable. I'll merge new features to branch |
You were too fast, I didn't do the changes recommended in the PR instructions (docs and changelog) should I do them in a follow-up ? |
I'll handle the changelogs and the docs repo is not public so @LiamConnors will have to take care of it. |
This feature have been requested multiple time by memebers of my team at work. I checked a bit on the web and multiple Threads on your forum mentioned it without providing any solution:
That's my first contribution to dash so i'm still a bit lost with everything in the repository but I simply tried to expose what is available in the react-select options. I only made changes to the JS exposed options but I'm unsure if I should modify anything from the python side.
I'll move forward with the contributor check list once I'm sure I didn't do anything stupid.
Thanks for your help.
Contributor Checklist
optionals
CHANGELOG.md