Skip to content

JupyterDash Fix - Alive Check #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

JupyterDash Fix - Alive Check #3171

merged 1 commit into from
Mar 6, 2025

Conversation

jpuerto-psc
Copy link
Contributor

@jpuerto-psc jpuerto-psc commented Feb 18, 2025 •
edited
Loading

This PR fixes an issue with the JupyterDash alive check routine. Namely, you must use the requests_pathname_prefix variable as part of the URL.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Fix alive check
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@gvwilson gvwilson added P2 considered for next cycle fix fixes something broken community community contribution labels Feb 18, 2025
T4rk1n
T4rk1n approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, thank you.

@T4rk1n T4rk1n merged commit 6bb0463 into plotly:dev Mar 6, 2025
3 checks passed
@T4rk1n T4rk1n mentioned this pull request Apr 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees
No one assigned
Labels
community community contribution fix fixes something broken P2 considered for next cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpuerto-psc @T4rk1n @gvwilson