-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Default to react 18 #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Default to react 18 #3093
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
92e0e3d
Set react default version to 18.3.1
T4rk1n 34b856e
Remove react 18 tests
T4rk1n 19ae407
Fix AppProvider default props
T4rk1n 2fb3a12
Fix dash-table tooltip ref
T4rk1n ac3776c
build
T4rk1n cb5b75b
Remove more defaultProps
T4rk1n 54f5cd5
replace react-resize-detector
T4rk1n 47e7606
Handle window resize when responsive
T4rk1n 577651b
Handle window resize when responsive
T4rk1n 0ba919e
refactor dash table refs to createRef
T4rk1n dd4bfd2
fix col ref
T4rk1n fcab0d1
Add back r1
T4rk1n 71bb86a
Update react-fontawesome
T4rk1n 0800904
build
T4rk1n 9ef0f6c
sleep before slider snapshot
T4rk1n ada24e5
sleep longer
T4rk1n 6317702
Merge branch 'dash-3.0' into default-react-18
T4rk1n e0e3ad9
build
T4rk1n 9a58dc6
Merge branch 'default-react-18' of github.com:plotly/dash into defaul…
T4rk1n 0f07e88
build
T4rk1n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 3 additions & 7 deletions
10
@plotly/dash-test-components/src/components/WidthComponent.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,13 @@ | ||
import PropTypes from 'prop-types'; | ||
import React, { Fragment } from 'react'; | ||
|
||
const WidthComponent = props => (<Fragment> | ||
{props.width} | ||
const WidthComponent = ({width = 0}) => (<Fragment> | ||
{width} | ||
</Fragment>); | ||
|
||
WidthComponent.propTypes = { | ||
id: PropTypes.string, | ||
width: PropTypes.number | ||
}; | ||
|
||
WidthComponent.defaultProps = { | ||
width: 0 | ||
}; | ||
|
||
export default WidthComponent; | ||
export default WidthComponent; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.