Fix unexpected behaviour of the cursor #2927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inserting a non valid character in the middle of a pattern, the cursor instantly jumps to the end of the word, instead of staying in that position. Added also some case tests.
gvwilson
changed the title
gvwilson
added
P2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2612
Issue: The cursor position in the input field was not maintained correctly after inserting an invalid character in the middle of the word, causing the cursor to jump to the end of that text.
Changes:
State Management: Updated the onChange method to ensure the cursor position is preserved after state updates.
Cursor Position Handling: Added logic to save and restore the cursor position using setTimeout, addressing the issue of cursor jumps.
Debounce Logic: Adjusted the method to handle debounce actions correctly in sequence with state updates.
Additional:
Added tests to verify that the cursor position remains correctly positioned after typing invalid characters in the input field.
Contributor Checklist