-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Make graph height more responsive #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
T4rk1n
merged 8 commits into
plotly:dev
from
nickmelnikov82:make-graph-height-more-responsive
May 29, 2025
Merged
Make graph height more responsive #1906
T4rk1n
merged 8 commits into
plotly:dev
from
nickmelnikov82:make-graph-height-more-responsive
May 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Mar 3, 2022
Co-authored-by: Alex Johnson <[email protected]>
c6ff8d6
to
4102339
Compare
4102339
to
bcbb3c1
Compare
alexcjohnson
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Worth doing a little bit of manual testing to see if we can find any significant cases where this causes problems... but to my eye this looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #1472 ddc.Graph isn't inheriting height from parent div as it does with width. This happens even when responsive = True is set. This PR allows Graph to be height responsive.
Contributor Checklist
optionals
CHANGELOG.md