Skip to content

Make graph height more responsive #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 29, 2025
Merged

Make graph height more responsive #1906

merged 8 commits into from
May 29, 2025

Conversation

nickmelnikov82
Copy link
Member

@nickmelnikov82 nickmelnikov82 commented Jan 31, 2022 •
edited
Loading

As described in issue #1472 ddc.Graph isn't inheriting height from parent div as it does with width. This happens even when responsive = True is set. This PR allows Graph to be height responsive.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Change dcc.Graph style
    • Add test
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

alexcjohnson
alexcjohnson reviewed Mar 3, 2022
View reviewed changes
@nickmelnikov82 nickmelnikov82 force-pushed the make-graph-height-more-responsive branch from c6ff8d6 to 4102339 Compare April 22, 2022 14:26
@nickmelnikov82 nickmelnikov82 force-pushed the make-graph-height-more-responsive branch from 4102339 to bcbb3c1 Compare April 27, 2022 13:17
@gvwilson gvwilson self-assigned this Jul 23, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added P2 considered for next cycle fix fixes something broken labels Aug 13, 2024
alexcjohnson
alexcjohnson approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Worth doing a little bit of manual testing to see if we can find any significant cases where this causes problems... but to my eye this looks good.

@gvwilson gvwilson added P1 needed for current cycle cs customer success and removed P2 considered for next cycle labels Jan 15, 2025
@T4rk1n T4rk1n merged commit 98d30e1 into plotly:dev May 29, 2025
8 of 10 checks passed
@T4rk1n T4rk1n mentioned this pull request May 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@marthacryan marthacryan Awaiting requested review from marthacryan

@T4rk1n T4rk1n Awaiting requested review from T4rk1n T4rk1n is a code owner

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees

@marthacryan marthacryan

@T4rk1n T4rk1n

Labels
cs customer success fix fixes something broken P1 needed for current cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickmelnikov82 @alexcjohnson @gvwilson @marthacryan @T4rk1n