Skip to content

Item type and asset type validation in Data and Subscriptions #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Apr 7, 2023
Merged

Item type and asset type validation in Data and Subscriptions #905

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
47c5002
Added validation for item types and thier options in an click epilog.
kevinlacaille Mar 31, 2023
b861774
Added validation for item types in get_asset() in the data client.
kevinlacaille Mar 31, 2023
5deba79
Added validation for item types in request.
kevinlacaille Mar 31, 2023
9358029
Added function to get supported assets and a validation function.
kevinlacaille Mar 31, 2023
19f088b
Added validation for asset types.
kevinlacaille Mar 31, 2023
688b23b
Added @translate_exceptions, but doesnt seem to work... hmmm
kevinlacaille Mar 31, 2023
19d5ac1
Added validation in try/except, but not sure that is the best way. TBD
kevinlacaille Mar 31, 2023
d3e5fe5
Removed annoyinng index into asset_types and now can validate all ass…
kevinlacaille Mar 31, 2023
a1819c9
Addeds tests for validate_asset_type.
kevinlacaille Mar 31, 2023
bd43ec2
Added tests for get_supported_assets.
kevinlacaille Mar 31, 2023
383deba
Bug fix: Flipped the order of item_type and name.
kevinlacaille Apr 3, 2023
6c7faa1
Bug fix: item_types doesnt need a list
kevinlacaille Apr 3, 2023
44a82b4
Removed list around item_types because item_types are now a click.Cho…
kevinlacaille Apr 3, 2023
4328639
Added translation of Spcification exception.
kevinlacaille Apr 3, 2023
adb4bba
Unsupported asset type.
kevinlacaille Apr 3, 2023
7df6274
Undoing bug fix. Will fix in a future ticket, #908.
kevinlacaille Apr 4, 2023
7e8fdaa
Changed item types back to a comma separated string.
kevinlacaille Apr 6, 2023
7e98d59
Validate asset types for each item type.
kevinlacaille Apr 6, 2023
51c4485
Added test for multiple item types and asset types.
kevinlacaille Apr 6, 2023
6a8eb49
Merge branch 'main' into item-type-case-insensitive-orders-subs-903
kevinlacaille Apr 6, 2023
bb70f60
Merge branch 'main' into item-type-case-insensitive-orders-subs-903
kevinlacaille Apr 6, 2023
bf0d3f5
Readded list to item_types.
kevinlacaille Apr 6, 2023
4ccb908
Unparamaterized test_request_catalog_success.
kevinlacaille Apr 6, 2023
baae55a
Added docstring and postfix to test_validate_asset_type.
kevinlacaille Apr 6, 2023
608fc51
Added callback function for item type.
kevinlacaille Apr 6, 2023
abbd994
Added docstring to validate_asset_type.
kevinlacaille Apr 6, 2023
b39f611
Reformatted data tests and duplicated data tests for subscriptions te…
kevinlacaille Apr 6, 2023
3512f80
Reformatted asset_type validation. Now accepts multiple asset types f…
kevinlacaille Apr 6, 2023
bd6b7df
ClientError raised if more than 1 item type is provided.
kevinlacaille Apr 6, 2023
f1af245
linting
kevinlacaille Apr 6, 2023
0ad9816
linting
kevinlacaille Apr 6, 2023
a3900d2
Renamed filename to better represent whats being tested.
kevinlacaille Apr 7, 2023
5e41ec0
Replace awkward text wrapping with nice continuous text.
kevinlacaille Apr 7, 2023
2d62bd2
Removed item type parametrization.
kevinlacaille Apr 7, 2023
c0cb296
Only test against one supported asset type.
kevinlacaille Apr 7, 2023
03d3308
Renamed filename to better represent whats being tested.
kevinlacaille Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion planet/cli/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,9 @@ async def search_update(ctx,
"""
async with data_client(ctx) as cl:
items = await cl.update_search(search_id,
name,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undoing this so that it can be fixed by #908. CC @jreiberkyle

item_types,
filter,
name,
daily_email)
echo_json(items, pretty)

Expand Down