Skip to content

Removed checksum argument from download_order #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

kevinlacaille
Copy link
Contributor

Related Issue(s):

Closes #856

Proposed Changes:

For inclusion in changelog (if applicable):

  1. Removed checksum argument from download_order.

Not intended for changelog:

Diff of User Interface

Old behavior:

async with orders_client(ctx) as cl:
    await cl.download_order(
        str(order_id),
        directory=Path(directory),
        overwrite=overwrite,
        progress_bar=not quiet,
    )
    if checksum:
        cl.validate_checksum(Path(directory, str(order_id)), checksum)

New behavior:
Same as before

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • [] I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:

@kevinlacaille kevinlacaille self-assigned this Mar 23, 2023
@kevinlacaille kevinlacaille marked this pull request as ready for review March 23, 2023 17:45
Base automatically changed from rc3dev-fixes to main March 24, 2023 17:04
Copy link
Contributor

@jreiberkyle jreiberkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL easiest non-doc PR review in the history of PRs. 🥇

@kevinlacaille kevinlacaille merged commit 92670cb into main Mar 27, 2023
@kevinlacaille kevinlacaille deleted the remove-checksum-arg-orders-api-856 branch March 27, 2023 18:38
@jreiberkyle jreiberkyle mentioned this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove checksum argument from orders.download_order()
2 participants