Skip to content

bugfix: Using f-string on subscription url #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

danielzre
Copy link

Hi

My company is currently integrating the subscription api and we found a small typo in this library. Can we merge this fix?

Output before fix:

planet.exceptions.BadQuery: {"error":{"reason":"Request failed schema validation","details":["parameter 'subscriptionId' in path has an error: JSON string doesn't match the format 'uuid (regular expression `^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$`)' | "]}}

Copy link
Contributor

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielzre thank you very much! The typo is small only when measured by the number of characters. I'll follow up with changes to the tests to prevent a regression.

@sgillies sgillies added the bug label Sep 6, 2022
@sgillies
Copy link
Contributor

sgillies commented Sep 6, 2022

@danielzre would a new pre-release with the fix be useful to you?

@danielzre
Copy link
Author

@sgillies Yes, it would be really useful hahah. Is there any ETA for this pre-release?

@sgillies
Copy link
Contributor

sgillies commented Sep 7, 2022

@danielzre I'm preparing 2.0a3 now. It will be on PyPI in about an hour.

@cholmes cholmes added this to the 2.0a3: Iterative Alpha Release milestone Sep 7, 2022
@cholmes
Copy link
Member

cholmes commented Sep 14, 2022

@danielzre - we really appreciate your contribution, I think you're the first non-planet contributor to the library! I'd love to talk to you further about what you're doing with Planet API's and what you'd be interested in us prioritizing in the new SDK. If you're up for it send me an email at cholmes [at] planet dotcom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants