Compatible bundle with item type error #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Exception to get_item_types, for test.
mkshah605
approved these changes
Aug 18, 2022
sgillies
reviewed
Aug 18, 2022
sgillies
reviewed
Aug 18, 2022
sgillies
reviewed
Aug 18, 2022
sgillies
reviewed
Aug 18, 2022
sgillies
suggested changes
Aug 18, 2022
There was a problem hiding this comment.
@kevinlacaille I may have found a issue that needs correction. I also made a couple suggestions to use Python language features for improved performance.
…and consistent. Raised a more verbose exception.
sgillies
reviewed
Aug 19, 2022
…tion in validate_item_type.
sgillies
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating
item_typebeforebundle, so that the item type compatibility exception will propagate before the bundle validation exception.Closes #618