Skip to content

fix incorrect search_filter arg in Data API documentation example #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

stephenhillier
Copy link
Contributor

Proposed Changes:

Fix incorrect arg in doc example.

filter -> search_filter

@stephenhillier
Copy link
Contributor Author

also note that use of search_filter here is inconsistent with other methods as well as our APIs themselves. We generally use filter. However, this would be a breaking change so some discussion is needed before changing that.

@stephenhillier stephenhillier merged commit 059766d into main Jun 25, 2025
9 checks passed
@stephenhillier stephenhillier deleted the steve/fix-docs-filter-arg branch June 25, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants