add Data API search tests using positional args #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenhillier
changed the title
| @@ -223,6 +224,43 @@ async def test_search_filter(item_descriptions, | |||
| assert items_list == item_descriptions | |||
|
|
|||
|
|
|||
| @respx.mock | |||
| @pytest.mark.anyio | |||
| async def test_search_filter_positional_args(item_descriptions, | |||
There was a problem hiding this comment.
nit: add a short docstring for this test.
There was a problem hiding this comment.
Also, compared to the below tests it looks like this tests 'quick-search' and pagination rather than vanilla search? If so what do you think about renaming this test to reflect quick-search + pagination?
There was a problem hiding this comment.
Pagination removed from test and docstring added
asonnenschein
approved these changes
May 31, 2024
There was a problem hiding this comment.
LGTM! I left a couple of nitpick comment, up to you to take the feedback or not @stephenhillier. Otherwise I don't see anything that should block this MR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
#1038
Proposed Changes:
Adds a test to the Data API client calling the search method using positional args.